* STill errorneous Treestyle sitemap
@ 2008-10-31 20:22 Sebastian Rose
2008-11-02 7:08 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Rose @ 2008-10-31 20:22 UTC (permalink / raw)
To: [emacs-orgmode]
Hi,
mea culpa: The treestyle sitemap is still wrong.
This tree
pub
|
+--A
| |
| +-- B
| | |
| | +-- file1
| |
| +-- C
| |
| +-- file2
_looks_ great in the sitemap, but _is_ wrong. The link to
C looks like this:
<a href="C">C</a>
instead of
<a href="A/C">C</a>
Two different ways to fix this:
A) Don't link to directories anymore.
I think this is quite a good solution, since in production
evironments those links will not work, if no index.html exists
in the directory. If it exists, it will be in the index file
anyway.
diff --git a/lisp/org-publish.el b/lisp/org-publish.el
index e0cf4bd..d2b4c1f 100644
--- a/lisp/org-publish.el
+++ b/lisp/org-publish.el
@@ -656,9 +656,8 @@ Default for INDEX-FILENAME is 'index.org'."
(pop subdirs))
(dolist (d subdirs)
(setq subdir (concat subdir d "/"))
- (insert (concat indent-str " + [[file:"
- subdir "][" d "/]]\n"))
- (setq indent-str (make-string
+ (insert (concat indent-str " + " d "\n"))
+ (setq indent-str (make-string
(+ (length indent-str) 2) ?\ )))))))
;; This is common to 'flat and 'tree
(insert (concat indent-str " + [[file:" link "]["
B) Fix it, so that the link is correct (no patch yet :-( ).
What do you think?
Sebastian
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: STill errorneous Treestyle sitemap
2008-10-31 20:22 STill errorneous Treestyle sitemap Sebastian Rose
@ 2008-11-02 7:08 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2008-11-02 7:08 UTC (permalink / raw)
To: sebastian_rose; +Cc: [emacs-orgmode]
Hi Sebastian,
Fix A seems good to me, I have added it, many thanks.
- Carsten
On Oct 31, 2008, at 9:22 PM, Sebastian Rose wrote:
> Hi,
>
>
> mea culpa: The treestyle sitemap is still wrong.
>
> This tree
>
> pub
> |
> +--A
> | |
> | +-- B
> | | |
> | | +-- file1
> | |
> | +-- C
> | |
> | +-- file2
>
>
> _looks_ great in the sitemap, but _is_ wrong. The link to
> C looks like this:
>
> <a href="C">C</a>
>
> instead of
>
> <a href="A/C">C</a>
>
>
>
> Two different ways to fix this:
>
>
> A) Don't link to directories anymore.
>
> I think this is quite a good solution, since in production
> evironments those links will not work, if no index.html exists
> in the directory. If it exists, it will be in the index file
> anyway.
>
> diff --git a/lisp/org-publish.el b/lisp/org-publish.el
> index e0cf4bd..d2b4c1f 100644
> --- a/lisp/org-publish.el
> +++ b/lisp/org-publish.el
> @@ -656,9 +656,8 @@ Default for INDEX-FILENAME is 'index.org'."
> (pop subdirs))
> (dolist (d subdirs)
> (setq subdir (concat subdir d "/"))
> - (insert (concat indent-str " + [[file:"
> - subdir "][" d "/]]\n"))
> - (setq indent-str (make-string
> + (insert (concat indent-str " + " d "\n"))
> + (setq indent-str (make-string
> (+ (length indent-str) 2) ?\ )))))))
> ;; This is common to 'flat and 'tree
> (insert (concat indent-str " + [[file:" link "]["
>
>
>
>
> B) Fix it, so that the link is correct (no patch yet :-( ).
>
>
>
>
> What do you think?
>
>
>
> Sebastian
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-02 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-31 20:22 STill errorneous Treestyle sitemap Sebastian Rose
2008-11-02 7:08 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).