From: Andreas Gerler <baron@bundesbrandschatzamt.de>
To: emacs-orgmode@gnu.org
Subject: [BUG] ob-sql sql-connection-alist
Date: Sun, 15 Jan 2023 17:00:37 +0100 [thread overview]
Message-ID: <C13D947F-7092-403E-B0D3-775B6AF06A38@bundesbrandschatzamt.de> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
HI!
Last week I heard about using ob-sql with credentials stored in the variable used by isql.
However I had to modify ob-sql to get it actually working.
Can somebody test the pach before I send in a commit?
#+begin_src sql :engine mysql :dbconnection testdb
show tables;
#+end_src
(setq sql-connection-alist
'((testdb (sql-product 'mysql)
(sql-server "127.0.0.1")
(sql-user "mysql”)
(sql-port 3306)
(sql-password “foo")
(sql-database "mysql"))))
I was considering writing another patch to map the sql-product to engine.
That way we could get rid of another parameter in the src block.
Opinions?
[-- Attachment #1.2: ob-sql.el.diff --]
[-- Type: application/octet-stream, Size: 882 bytes --]
diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
index 39a4573a5..92a157085 100644
--- a/lisp/ob-sql.el
+++ b/lisp/ob-sql.el
@@ -1,6 +1,6 @@
;;; ob-sql.el --- Babel Functions for SQL -*- lexical-binding: t; -*-
-;; Copyright (C) 2009-2023 Free Software Foundation, Inc.
+;; Copyright (C) 2009-2022 Free Software Foundation, Inc.
;; Author: Eric Schulte
;; Maintainer: Daniel Kraus <daniel@kraus.my>
@@ -234,7 +234,7 @@ database connections."
(:database . sql-database)))
(mapped-name (cdr (assq name name-mapping))))
(cadr (assq mapped-name
- (cdr (assoc dbconnection sql-connection-alist))))))))
+ (cdr (assoc-string dbconnection sql-connection-alist t))))))))
(defun org-babel-execute:sql (body params)
"Execute a block of Sql code with Babel.
[-- Attachment #1.3: Type: text/plain, Size: 102 bytes --]
Thanks in advance…
Andreas Gerler
—
http://www.bundesbrandschatzamt.de/~baron
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 874 bytes --]
next reply other threads:[~2023-01-15 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 16:00 Andreas Gerler [this message]
2023-01-16 10:25 ` [BUG] ob-sql sql-connection-alist Daniel Kraus
2023-01-20 17:24 ` Andreas Gerler
2023-01-20 17:30 ` Andreas Gerler
2023-01-20 20:41 ` Daniel Kraus
2023-01-20 21:03 ` Andreas Gerler
2023-01-21 8:48 ` Ihor Radchenko
2023-01-21 12:15 ` Andreas Gerler
2023-01-22 10:58 ` Bastien Guerry
2023-01-26 10:44 ` Bastien Guerry
2023-01-27 13:13 ` Ihor Radchenko
2023-01-27 13:18 ` Ihor Radchenko
2023-01-27 16:58 ` Andreas Gerler
2023-01-28 14:13 ` Andreas Gerler
2023-01-30 16:59 ` Daniel Kraus
2023-01-16 10:33 ` Ihor Radchenko
2023-01-16 10:45 ` Daniel Kraus
2023-01-16 11:05 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C13D947F-7092-403E-B0D3-775B6AF06A38@bundesbrandschatzamt.de \
--to=baron@bundesbrandschatzamt.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).