emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Daniel Kraus <daniel@kraus.my>
To: Andreas Gerler <baron@bundesbrandschatzamt.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] ob-sql sql-connection-alist
Date: Mon, 16 Jan 2023 11:25:18 +0100	[thread overview]
Message-ID: <87cz7ebwig.fsf@kraus.my> (raw)
In-Reply-To: <C13D947F-7092-403E-B0D3-775B6AF06A38@bundesbrandschatzamt.de>

Hi!

Andreas Gerler <baron@bundesbrandschatzamt.de> writes:

> Last week I heard about using ob-sql with credentials stored in the variable used by isql.
> However I had to modify ob-sql to get it actually working.
> Can somebody test the pach before I send in a commit?
>
> #+begin_src sql :engine mysql :dbconnection testdb
> show tables;
> #+end_src

I actually use this feature daily.
You have to quote the dbconnection. So this works currently:

> #+begin_src sql :engine mysql :dbconnection 'testdb

but I would agree that not needing the quote makes sense.
And since `assoc-string` works with symbol and string (i.e. it's backwards compatible)
I would install the patch if you send it.

> I was considering writing another patch to map the sql-product to engine.
> That way we could get rid of another parameter in the src block.
> Opinions?

I agree. Specifying :engine when it's already in the connection-alist is unnecessary.

Thanks,
  Daniel

next prev parent reply	other threads:[~2023-01-16 10:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 16:00 [BUG] ob-sql sql-connection-alist Andreas Gerler
2023-01-16 10:25 ` Daniel Kraus [this message]
2023-01-20 17:24   ` Andreas Gerler
2023-01-20 17:30     ` Andreas Gerler
2023-01-20 20:41       ` Daniel Kraus
2023-01-20 21:03         ` Andreas Gerler
2023-01-21  8:48         ` Ihor Radchenko
2023-01-21 12:15           ` Andreas Gerler
2023-01-22 10:58           ` Bastien Guerry
2023-01-26 10:44           ` Bastien Guerry
2023-01-27 13:13             ` Ihor Radchenko
2023-01-27 13:18             ` Ihor Radchenko
2023-01-27 16:58               ` Andreas Gerler
2023-01-28 14:13                 ` Andreas Gerler
2023-01-30 16:59                   ` Daniel Kraus
2023-01-16 10:33 ` Ihor Radchenko
2023-01-16 10:45   ` Daniel Kraus
2023-01-16 11:05     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz7ebwig.fsf@kraus.my \
    --to=daniel@kraus.my \
    --cc=baron@bundesbrandschatzamt.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).