* [PATCH] Avoid lisp error with (org-deadline nil "+1d")
@ 2011-11-21 22:39 Peter Münster
2011-11-22 22:45 ` Carsten Dominik
0 siblings, 1 reply; 9+ messages in thread
From: Peter Münster @ 2011-11-21 22:39 UTC (permalink / raw)
To: emacs-orgmode
* lisp/org.el (parse-time-weekdays): Must not be void.
TINYCHANGE
---
lisp/org.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 253703b..41d418a 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15229,7 +15229,7 @@ user."
(setq org-read-date-analyze-futurep futurep)
(list second minute hour day month year)))
-(defvar parse-time-weekdays)
+(defvar parse-time-weekdays nil)
(defun org-read-date-get-relative (s today default)
"Check string S for special relative date string.
--
1.7.3.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-21 22:39 [PATCH] Avoid lisp error with (org-deadline nil "+1d") Peter Münster
@ 2011-11-22 22:45 ` Carsten Dominik
2011-11-23 6:14 ` Peter Münster
0 siblings, 1 reply; 9+ messages in thread
From: Carsten Dominik @ 2011-11-22 22:45 UTC (permalink / raw)
To: Peter Münster; +Cc: emacs-orgmode
On 21.11.2011, at 23:39, Peter Münster wrote:
> * lisp/org.el (parse-time-weekdays): Must not be void.
>
> TINYCHANGE
> ---
> lisp/org.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 253703b..41d418a 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -15229,7 +15229,7 @@ user."
> (setq org-read-date-analyze-futurep futurep)
> (list second minute hour day month year)))
>
> -(defvar parse-time-weekdays)
> +(defvar parse-time-weekdays nil)
This is not allowed, we cannot define a variable defined in another package.
Can you send a backtrace of the error, please?
- Carsten
>
> (defun org-read-date-get-relative (s today default)
> "Check string S for special relative date string.
> --
> 1.7.3.4
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-22 22:45 ` Carsten Dominik
@ 2011-11-23 6:14 ` Peter Münster
2011-11-23 6:36 ` Carsten Dominik
0 siblings, 1 reply; 9+ messages in thread
From: Peter Münster @ 2011-11-23 6:14 UTC (permalink / raw)
To: emacs-orgmode
On Tue, Nov 22 2011, Carsten Dominik wrote:
> This is not allowed, we cannot define a variable defined in another package.
Oh, pardon.
> Can you send a backtrace of the error, please?
Of course (from "emacs -Q"):
--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-variable parse-time-weekdays)
org-read-date-get-relative("+1d" (20172 36366 853978) (20170 55280))
org-read-date-analyze("+1d" (20170 55280) (0 0 0 22 11 2011 2 nil 3600))
byte-code("\b\306>\203J. \203.\0 ;\203J.\307\310 \"\203J.\212\311\312!\210\212\313 \210`).\314\b\315=\203-.\v\202..\f\n\312#\203I.\316\317!.\320\321\322.!\".3.\205G.\323.!.4)\b\203y. ;\203i.\307\310 \"\203i.\320\321\324 .3\325.3!#\"\202x. \206x.\326\327\330\327\211.3.4&.\x11.5\203\244.\b\331\235\203\244.\b\315=\203\217.\x0e6\202\221.\x0e7\332\261.\210\333 .8\327\211\211.9C&.\210\327.\212\214\327\211\211\211\211.:.\x1e;.<.=\311\312!\210\334.>\335P!\210\317\225b\210i.=\336\225b\210m\203\324.\337c\210\202\327.\317u\210\b\204\351.\334\340.?P!\204\351.\341\342\327\"\210\334.>!\204\f.\334\343.@\344Q!\203\f.\316\317!.A\232\204\f.\336\224\336\225}\210\202!.\345\337!\210\346u\210``}\210.B\203!.\347.=!\210\b.CB.<.<\203s.\x0e<\211A.<@\211.;\315=\203C.\314\v\327\312#\204b.\x0e;\350=\203R.\314\f\327\312#\204b.\x0e;\351=\203'.\314.D\327\312#\203'.\352\353!\210\334\354!\203'.\352\353!\210\202'.\334\355!\203}.\352\353!\210.B\203\213.n\203\213.\347.=!\210\b\203\375.n\204\237.`Sf\356=\204\237.\332\202\240.\353\b\315=\203\253.\x0e6\202\276.\b\350=\203\266.\x0e7\202\276.\b\351=\205\276.\x0eE\332\261.\210\333 .8\206\321.\b\351=\205\321.\x0eF\b\351=\327\211.9C&.\x15n\204\367.`Sf\356=\204\367.\327f\357>\204\367.m\204\367.\332\202\370.\353c\210\317\x7f\210eb\210~\210\334\360!\203.\x02`Sf\361\232\203.\x02`S\362 |\210..\a\207" [what time end org-scheduled-time-regexp org-deadline-time-regexp ts (scheduled deadline) string-match "^[-+]+[0-9]" org-back-to-heading t outline-next-heading re-search-forward scheduled match-string 1 apply encode-time org-parse-time-string org-get-compact-tod org-read-date-analyze decode-time org-read-date nil to-time (scheduled deadline) " " org-insert-time-stamp looking-at "\\( *\\)[^.\n]*" 0 "\n" "[ ]*" throw exit "[^.\n]*?" "[^.\n]*" insert-before-markers -1 org-indent-to-column deadline closed replace-match "" "--+<[^>]+>" "^[ ]+" 32 (32 10) "[ ]*\n" 10 ...] 8)
org-add-planning-info(deadline "+1d" closed)
org-deadline(nil "+1d")
eval((org-deadline nil "+1d") nil)
eval-expression((org-deadline nil "+1d") nil)
call-interactively(eval-expression nil nil)
--8<---------------cut here---------------end--------------->8---
--
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-23 6:14 ` Peter Münster
@ 2011-11-23 6:36 ` Carsten Dominik
2011-11-23 20:59 ` Peter Münster
0 siblings, 1 reply; 9+ messages in thread
From: Carsten Dominik @ 2011-11-23 6:36 UTC (permalink / raw)
To: Peter Münster; +Cc: emacs-orgmode
Fixed, thanks, please verify.
- Carsten
On 23.11.2011, at 07:14, Peter Münster wrote:
> On Tue, Nov 22 2011, Carsten Dominik wrote:
>
>> This is not allowed, we cannot define a variable defined in another package.
>
> Oh, pardon.
>
>
>> Can you send a backtrace of the error, please?
>
> Of course (from "emacs -Q"):
>
> --8<---------------cut here---------------start------------->8---
> Debugger entered--Lisp error: (void-variable parse-time-weekdays)
> org-read-date-get-relative("+1d" (20172 36366 853978) (20170 55280))
> org-read-date-analyze("+1d" (20170 55280) (0 0 0 22 11 2011 2 nil 3600))
> byte-code("\b\306>\203J. \203. ;\203J.\307\310 \"\203J.\212\311\312!\210\212\313 \210`).\314\b\315=\203-.\v\202..\f\n\312#\203I.\316\317!.\320\321\322.!\".3.\205G.\323.!.4)\b\203y. ;\203i.\307\310 \"\203i.\320\321\324 .3\325.3!#\"\202x. \206x.\326\327\330\327\211.3.4&.\x11.5\203\244.\b\331\235\203\244.\b\315=\203\217.\x0e6\202\221.\x0e7\332\261.\210\333 .8\327\211\211.9C&.\210\327.\212\214\327\211\211\211\211.:.\x1e;.<.=\311\312!\210\334.>\335P!\210\317\225b\210i.=\336\225b\210m\203\324.\337c\210\202\327.\317u\210\b\204\351.\334\340.?P!\204\351.\341\342\327\"\210\334.>!\204\f.\334\343.@\344Q!\203\f.\316\317!.A\232\204\f.\336\224\336\225}\210\202!.\345\337!\210\346u\210``}\210.B\203!.\347.=!\210\b.CB.<.<\203s.\x0e<\211A.<@\211.;\315=\203C.\314\v\327\312#\204b.\x0e;\350=\203R.\314\f\327\312#\204b.\x0e;\351=\203'.\314.D\327\312#\203'.\352\353!\210\334\354!\203'.\352\353!\210\202'.\334\355!\203}.\352\353!\210.B\203\213.n\203\213.\347.=!\210\b\203\375.n\204\237.`Sf\356=\204\237.\332\202\240.\353\b\315=\203\253.\x0e6\202\276.\b\350=\203\266.\x0e7\202\276.\b\351=\205\276.\x0eE\332\261.\210\333 .8\206\321.\b\351=\205\321.\x0eF\b\351=\327\211.9C&.\x15n\204\367.`Sf\356=\204\367.\327f\357>\204\367.m\204\367.\332\202\370.\353c\210\317\x7f\210eb\210~\210\334\360!\203.\x02`Sf\361\232\203.\x02`S\362 |\210..\a\207" [what time end org-scheduled-time-regexp org-deadline-time-regexp ts (scheduled deadline) string-match "^[-+]+[0-9]" org-back-to-heading t outline-next-heading re-search-forward scheduled match-string 1 apply encode-time org-parse-time-string org-get-compact-tod org-read-date-analyze decode-time org-read-date nil to-time (scheduled deadline) " " org-insert-time-stamp looking-at "\\( *\\)[^.\n]*" 0 "\n" "[ ]*" throw exit "[^.\n]*?" "[^.\n]*" insert-before-markers -1 org-indent-to-column deadline closed replace-match "" "--+<[^>]+>" "^[ ]+" 32 (32 10) "[ ]*\n" 10 ...] 8)
> org-add-planning-info(deadline "+1d" closed)
> org-deadline(nil "+1d")
> eval((org-deadline nil "+1d") nil)
> eval-expression((org-deadline nil "+1d") nil)
> call-interactively(eval-expression nil nil)
> --8<---------------cut here---------------end--------------->8---
>
> --
> Peter
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-23 6:36 ` Carsten Dominik
@ 2011-11-23 20:59 ` Peter Münster
2011-11-23 21:13 ` Nick Dokos
0 siblings, 1 reply; 9+ messages in thread
From: Peter Münster @ 2011-11-23 20:59 UTC (permalink / raw)
To: emacs-orgmode
On Wed, Nov 23 2011, Carsten Dominik wrote:
> Fixed, thanks, please verify.
Verified: ok, thanks.
Is `(defvar parse-time-weekdays)' still needed then? And if yes, why?
--
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-23 20:59 ` Peter Münster
@ 2011-11-23 21:13 ` Nick Dokos
2011-11-23 22:33 ` Peter Münster
0 siblings, 1 reply; 9+ messages in thread
From: Nick Dokos @ 2011-11-23 21:13 UTC (permalink / raw)
To: Peter =?utf-8?Q?M=C3=BCnster?=; +Cc: nicholas.dokos, emacs-orgmode
Peter Münster <pmlists@free.fr> wrote:
> On Wed, Nov 23 2011, Carsten Dominik wrote:
>
> > Fixed, thanks, please verify.
>
> Verified: ok, thanks.
>
> Is `(defvar parse-time-weekdays)' still needed then? And if yes, why?
>
Generally speaking, defvars like this tell the compiler to shut up about
the "free" variable. You can see if it is needed, by commenting out the
defvar and then trying to compile the file.
Nick
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-23 21:13 ` Nick Dokos
@ 2011-11-23 22:33 ` Peter Münster
2011-11-23 23:21 ` Nick Dokos
0 siblings, 1 reply; 9+ messages in thread
From: Peter Münster @ 2011-11-23 22:33 UTC (permalink / raw)
To: emacs-orgmode
On Wed, Nov 23 2011, Nick Dokos wrote:
> Generally speaking, defvars like this tell the compiler to shut up about
> the "free" variable. You can see if it is needed, by commenting out the
> defvar and then trying to compile the file.
Indeed, now there are 30 warnings instead of only 29 ... ;)
Thanks for the explanation!
--
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] Avoid lisp error with (org-deadline nil "+1d")
2011-11-23 22:33 ` Peter Münster
@ 2011-11-23 23:21 ` Nick Dokos
2012-02-18 20:34 ` Peter Münster
0 siblings, 1 reply; 9+ messages in thread
From: Nick Dokos @ 2011-11-23 23:21 UTC (permalink / raw)
To: Peter =?utf-8?Q?M=C3=BCnster?=; +Cc: nicholas.dokos, emacs-orgmode
Peter Münster <pmlists@free.fr> wrote:
> On Wed, Nov 23 2011, Nick Dokos wrote:
>
> > Generally speaking, defvars like this tell the compiler to shut up about
> > the "free" variable. You can see if it is needed, by commenting out the
> > defvar and then trying to compile the file.
>
> Indeed, now there are 30 warnings instead of only 29 ... ;)
> Thanks for the explanation!
>
Are they free variable warnings? If so, you now know how to fix them:
go wild :-)
Nick
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-02-18 20:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-21 22:39 [PATCH] Avoid lisp error with (org-deadline nil "+1d") Peter Münster
2011-11-22 22:45 ` Carsten Dominik
2011-11-23 6:14 ` Peter Münster
2011-11-23 6:36 ` Carsten Dominik
2011-11-23 20:59 ` Peter Münster
2011-11-23 21:13 ` Nick Dokos
2011-11-23 22:33 ` Peter Münster
2011-11-23 23:21 ` Nick Dokos
2012-02-18 20:34 ` Peter Münster
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).