Re: [PATCH] Rename temporary buffer to remove dependency of `flet' macro

From: Carsten Dominik <carsten.dominik@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Rename temporary buffer to remove dependency of `flet' macro
Date: Wed, 18 Aug 2010 10:43:54 +0200	[thread overview]
Message-ID: <AC179B98-F4D4-46B3-B139-D9FEB83DA218@gmail.com> (raw)
In-Reply-To: <1281630669-6565-2-git-send-email-dmaus@ictsoc.de>

Hi David,

I trust that you will apply this patch once you are satisfied with it.

Best wishes

- Carsten

On Aug 12, 2010, at 6:31 PM, David Maus wrote:

> * org-agenda.el (org-write-agenda): Rename temporary buffer to remove
> dependency of `flet' macro.
> ---
> lisp/org-agenda.el |   12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 61b867b..f2592ad 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -2454,12 +2454,14 @@ higher priority settings."
>    ((string-match "\\.html?\\'" file) (require 'htmlize))
>    ((string-match "\\.ps\\'" file) (require 'ps-print)))
>   (org-let (if nosettings nil org-agenda-exporter-settings)
> -    `(save-excursion
> +    '(save-excursion
>        (save-window-excursion
> 	 (org-agenda-mark-filtered-text)
> 	 (let ((bs (copy-sequence (buffer-string))) beg)
> 	   (org-agenda-unmark-filtered-text)
> 	   (with-temp-buffer
> +	     (rename-buffer "Agenda View" t)
> +	     (set-buffer-modified-p nil)
> 	     (insert bs)
> 	     (org-agenda-remove-marked-text 'org-filtered)
> 	     (while (setq beg (text-property-any (point-min) (point-max)
> @@ -2486,14 +2488,12 @@ higher priority settings."
> 	       (message "HTML written to %s" file))
> 	      ((string-match "\\.ps\\'" file)
> 	       (require 'ps-print)
> -	       ,(flet ((ps-get-buffer-name () "Agenda View"))
> -		  (ps-print-buffer-with-faces file))
> +	       (ps-print-buffer-with-faces file)
> 	       (message "Postscript written to %s" file))
> 	      ((string-match "\\.pdf\\'" file)
> 	       (require 'ps-print)
> -	       ,(flet ((ps-get-buffer-name () "Agenda View"))
> -		  (ps-print-buffer-with-faces
> -		   (concat (file-name-sans-extension file) ".ps")))
> +	       (ps-print-buffer-with-faces
> +		(concat (file-name-sans-extension file) ".ps"))
> 	       (call-process "ps2pdf" nil nil nil
> 			     (expand-file-name
> 			      (concat (file-name-sans-extension file) ".ps"))
> -- 
> 1.7.1
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten