From: Robert Goldman <rpgoldman@sift.info>
To: David Maus <dmaus@ictsoc.de>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: PATCH: Fix for agenda problems
Date: Sun, 01 Aug 2010 20:42:26 -0500 [thread overview]
Message-ID: <4C562282.5090802@sift.info> (raw)
In-Reply-To: <874ofefarb.wl%dmaus@ictsoc.de>
On 8/1/10 Aug 1 -1:28 PM, David Maus wrote:
> Robert Goldman wrote:
>> [1 <text/plain; ISO-8859-1 (7bit)>]
>> As far as I can tell, the current version of org-write-agenda evaluates
>> ps-print-buffer-with-faces too eagerly. I tripped over this because
>> aquamacs 2.0, which I'm using, seems to have ps-printing code that
>> conflicts with org-mode's expectation.
>
>> The attached patch tries to fix this, but does not do the job
>> particularly elegantly. Instead of EVALUATING the flet form, it
>> MACROEXPANDS that form, which I believe is correct in this context.
>
> Yes, the intension of backquoting the flet macro was macroexpansion,
> not evaluation. And it should work to solve the issue with cl not
> loaded on runtime when calling `org-agenda-write'[1].
>
> Best,
> -- David
>
> [1] Cf. http://thread.gmane.org/gmane.emacs.orgmode/26132/focus=26698
Are you sure that my patch will work properly? I was looking at it, and
it seems like the use of org-let might cause the list (the code) to be
evaluated at run-time, and not at compile time, right?
Here's org-let:
(defun org-let (list &rest body)
(eval (cons 'let (cons list body))))
(put 'org-let 'lisp-indent-function 1)
It occurs in org-agenda. Question: does this mean that the backquoted
expression will be evaluated at run-time, or is the compiler aggressive
enough to do it at compile-time? This is something I /should/ know, but
don't....
best,
r
next prev parent reply other threads:[~2010-08-02 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 23:21 PATCH: Fix for agenda problems Robert Goldman
2010-08-01 18:28 ` David Maus
2010-08-02 1:42 ` Robert Goldman [this message]
2010-08-02 16:53 ` David Maus
2010-08-12 16:31 ` [PATCH] Remove dependency of flet in org-write-agenda David Maus
2010-08-12 16:31 ` [PATCH] Rename temporary buffer to remove dependency of `flet' macro David Maus
2010-08-18 8:43 ` Carsten Dominik
2010-08-01 18:28 ` PATCH: Fix for agenda problems David Maus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C562282.5090802@sift.info \
--to=rpgoldman@sift.info \
--cc=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).