From: Nathaniel Flath <flat0103@gmail.com>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>,
Jacob Mitchell <jacob.d.mitchell@gmail.com>,
org-mode List <emacs-orgmode@gnu.org>,
Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Re: [PATCH] Alphabetical ordered lists
Date: Fri, 26 Nov 2010 20:39:57 -0800 [thread overview]
Message-ID: <AANLkTi=D3vs0od75TBFD6ftycQi0SDi3bthNUg6FhCh1@mail.gmail.com> (raw)
In-Reply-To: <87bp5hi4qy.wl%n.goaziou@gmail.com>
I'm working on your comments, should have another patch in the next day or so.
The only thing I had issue with was the comment about
org-item-beginning-re: I prefer it as a function for the reasons you
mention, but I'm not particularly attached to this. Does anyone else
have an opinion?
Thanks,
Nathaniel Flath
On Mon, Nov 22, 2010 at 10:37 AM, Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
>>>>>> Nathaniel Flath writes:
>
>> although I'm not an expert in the exporting. Let me know if there's
>> anything else, or if I screwed up anything when trying to figure out
>> how to make a git patch(looks like it worked, though.)
>
> I looked at your patch and here is what I've noticed so far:
>
>
> - There's a bug in `org-cycle-list-bullet' where
> org-list-can-be-alphabetical is called with argument missing.
>
> - In `org-cycle-list-bullet', variable `top' stores list top point,
> make use of it instead of recomputing it.
>
> - There's a typo in `org-list-parse-list' (ogr-looking-at-p instead of
> org-looking-at-p)
>
> - Some parts of the patch are only white-space changes (for example a
> change in `org-list-automatic-rules' but there are others). You
> shouldn't include them, as it is not the purpose of the patch.
>
> It doesn't help understanding your patch either.
>
> - Why did you remove all code comments about lists in org-docbook.el?
>
> - This is not a bug but are you sure you want to make
> org-item-beginning-re a function? I understand that it permits an
> user changing the value of `org-alphabetical-lists' to avoid
> reloading Org, but it looks like syntax overweight to me.
>
> I mean, anyone wanting to look for a list item will have to remember
> that it must do a re-search on a function and not a string.
>
>
> Hoping that helps,
>
> Regards,
>
> -- Nicolas
>
next prev parent reply other threads:[~2010-11-27 4:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 20:27 [PATCH] Alphabetical ordered lists Nathaniel Flath
2010-07-29 21:07 ` Nick Dokos
2010-08-01 18:33 ` David Maus
2010-08-02 9:31 ` Nicolas Goaziou
2010-08-27 8:11 ` Carsten Dominik
2010-08-27 10:53 ` Bernt Hansen
2010-08-27 12:44 ` Jacob Mitchell
2010-08-27 13:01 ` Nathaniel Flath
2010-09-18 7:43 ` Nathaniel Flath
2010-09-21 12:48 ` Carsten Dominik
2010-09-21 16:46 ` Nicolas Goaziou
2010-09-26 17:36 ` Nicolas Goaziou
2010-09-26 22:16 ` Nathaniel Flath
2010-09-27 6:55 ` Nicolas Goaziou
2010-09-28 16:12 ` Carsten Dominik
2010-09-29 15:49 ` Carsten Dominik
2010-09-29 16:50 ` Nathaniel Flath
2010-09-29 17:46 ` Nicolas Goaziou
2010-10-01 1:13 ` Nathaniel Flath
2010-10-04 8:33 ` Carsten Dominik
2010-10-04 17:18 ` Nicolas Goaziou
2010-10-05 0:07 ` Sebastian Rose
2010-10-05 0:21 ` Nathaniel Flath
2010-10-05 7:40 ` Carsten Dominik
2010-10-21 4:44 ` Nathaniel Flath
2010-10-22 5:30 ` Nathaniel Flath
2010-10-22 8:13 ` Carsten Dominik
2010-10-23 1:04 ` Nathaniel Flath
2010-10-26 8:21 ` Nicolas Goaziou
2010-10-26 8:23 ` Carsten Dominik
2010-10-28 7:17 ` Nathaniel Flath
2010-11-11 7:16 ` Nathaniel Flath
2010-11-11 8:57 ` Nicolas Goaziou
2010-11-13 15:16 ` Nicolas Goaziou
2010-11-22 4:45 ` Nathaniel Flath
2010-11-22 13:37 ` Bernt Hansen
2010-11-22 18:37 ` Nicolas Goaziou
2010-11-27 4:39 ` Nathaniel Flath [this message]
2010-12-11 2:41 ` Nathaniel Flath
2010-12-20 18:25 ` Nicolas Goaziou
2011-01-12 20:05 ` Nathaniel Flath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=D3vs0od75TBFD6ftycQi0SDi3bthNUg6FhCh1@mail.gmail.com' \
--to=flat0103@gmail.com \
--cc=bernt@norang.ca \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=jacob.d.mitchell@gmail.com \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).