From: Bernt Hansen <bernt@norang.ca>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>,
Jacob Mitchell <jacob.d.mitchell@gmail.com>,
Nicolas Goaziou <n.goaziou@gmail.com>,
Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Re: [PATCH] Alphabetical ordered lists
Date: Mon, 22 Nov 2010 08:37:21 -0500 [thread overview]
Message-ID: <87y68lwkby.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <AANLkTimZOMqEav66rMc0Brtte7sRb81cZrfHFicYOmO=@mail.gmail.com> (Nathaniel Flath's message of "Sun, 21 Nov 2010 20:45:27 -0800")
Nathaniel Flath <flat0103@gmail.com> writes:
> Let me know if there's anything else, or if I screwed up anything
> when trying to figure out how to make a git patch(looks like it
> worked, though.)
>
> From 3b46feec08ec4c93f098dbdc6a4590f95afc0e68 Mon Sep 17 00:00:00 2001
> From: unknown <nflath@.(none)>
> Date: Sun, 21 Nov 2010 20:40:02 -0800
> Subject: [PATCH] Squashed commit of the following:
>
> commit 7e9c81b27591c010cc0b6b016ee0e669ef5a304c
> Author: unknown <nflath@.(none)>
> Date: Sun Nov 21 20:01:42 2010 -0800
>
> New version of alpha lists
>
> commit b3fd5cc57b7f1bd62ee1f5e0d8a1cf57ca14cfc2
> Author: unknown <nflath@.(none)>
> Date: Thu Oct 21 22:28:44 2010 -0700
>
> foo2
>
> commit 00279a9b53b75baf1e3e13fc0bf0926421dddd25
> Author: unknown <nflath@.(none)>
> Date: Thu Oct 21 22:27:01 2010 -0700
>
> foo
>
> Fixup alphabetical lists patch
> ---
> lisp/org-capture.el | 4 +-
Hi Nathaniel. There are a few issues with the commit message in this
patch.
1. Invalid email address
2. A list of commits with useless information in it (foo, foo2)
3. Summary line (Squashed commot of the following:) really isn't
useful on it's own
The subject line (line 1 of the commit message) should be standalone and
concisely state what the commit is for -- so you don't have to read the
rest unless that interests you.
The body of the commit message is for detailed descriptions of the
change. You should delete the other squashed commit info since it is
not useful. Describing what exactly you fixed up in the description
would be preferable to 'fixed alphabetical lists patch'. 6 months from
now nobody (including you) will know what you fixed without actually
reading the patch details.
Regards,
Bernt
next prev parent reply other threads:[~2010-11-22 13:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 20:27 [PATCH] Alphabetical ordered lists Nathaniel Flath
2010-07-29 21:07 ` Nick Dokos
2010-08-01 18:33 ` David Maus
2010-08-02 9:31 ` Nicolas Goaziou
2010-08-27 8:11 ` Carsten Dominik
2010-08-27 10:53 ` Bernt Hansen
2010-08-27 12:44 ` Jacob Mitchell
2010-08-27 13:01 ` Nathaniel Flath
2010-09-18 7:43 ` Nathaniel Flath
2010-09-21 12:48 ` Carsten Dominik
2010-09-21 16:46 ` Nicolas Goaziou
2010-09-26 17:36 ` Nicolas Goaziou
2010-09-26 22:16 ` Nathaniel Flath
2010-09-27 6:55 ` Nicolas Goaziou
2010-09-28 16:12 ` Carsten Dominik
2010-09-29 15:49 ` Carsten Dominik
2010-09-29 16:50 ` Nathaniel Flath
2010-09-29 17:46 ` Nicolas Goaziou
2010-10-01 1:13 ` Nathaniel Flath
2010-10-04 8:33 ` Carsten Dominik
2010-10-04 17:18 ` Nicolas Goaziou
2010-10-05 0:07 ` Sebastian Rose
2010-10-05 0:21 ` Nathaniel Flath
2010-10-05 7:40 ` Carsten Dominik
2010-10-21 4:44 ` Nathaniel Flath
2010-10-22 5:30 ` Nathaniel Flath
2010-10-22 8:13 ` Carsten Dominik
2010-10-23 1:04 ` Nathaniel Flath
2010-10-26 8:21 ` Nicolas Goaziou
2010-10-26 8:23 ` Carsten Dominik
2010-10-28 7:17 ` Nathaniel Flath
2010-11-11 7:16 ` Nathaniel Flath
2010-11-11 8:57 ` Nicolas Goaziou
2010-11-13 15:16 ` Nicolas Goaziou
2010-11-22 4:45 ` Nathaniel Flath
2010-11-22 13:37 ` Bernt Hansen [this message]
2010-11-22 18:37 ` Nicolas Goaziou
2010-11-27 4:39 ` Nathaniel Flath
2010-12-11 2:41 ` Nathaniel Flath
2010-12-20 18:25 ` Nicolas Goaziou
2011-01-12 20:05 ` Nathaniel Flath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y68lwkby.fsf@gollum.intra.norang.ca \
--to=bernt@norang.ca \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=flat0103@gmail.com \
--cc=jacob.d.mitchell@gmail.com \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).