From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: Julien Danjou <julien@danjou.info>,
Eric S Fraga <ucecesf@ucl.ac.uk>,
emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda: rework ndays and span handling
Date: Fri, 3 Dec 2010 09:00:53 +0100 [thread overview]
Message-ID: <A37FBED4-6D78-4D86-8DA1-3E6CA5867113@gmail.com> (raw)
In-Reply-To: <87fwufhah5.fsf@gollum.intra.norang.ca>
On Dec 3, 2010, at 3:11 AM, Bernt Hansen wrote:
> Julien Danjou <julien@danjou.info> writes:
>
>> On Wed, Dec 01 2010, Eric S Fraga wrote:
>>
>>> Mostly works fine but there is one problem I have encountered. If
>>> you
>>> change your view (mine defaults to day so I sometimes switch to week
>>> view), you can go forward and backward as expected. However, if you
>>> /jump/ (j in agenda view) to a given date, the view resets to the
>>> default (well, to single day view in my case). I prefer the view to
>>> remain as I have specified it last until I change it myself.
>>
>> Good catch. Patch updated fixing that.
>
> Hi Julien,
>
> I tried your patch out tonight and I'm confused about org-agenda-
> ndays.
> This is stated as obsolete (since 24.1 ? what's that?) but the default
> for org-agenda-span doesn't seem to be set based on the existing value
> of org-agenda-ndays. Is that on purpose?
>
> I'm fine with customizing org-agenda-span as long as it's documented
> that this needs to be done for the next version of org-mode that
> includes your patch.
I guess making org-agenda-ndays should be made an alias for org-agenda-
span.
>
> I also noticed the display on the modeline says 'Day', 'Week',
> 'Month',
> or 'Year' when displaying the agenda with 'd', 'w', 'v m', and 'v y'
> which is great. However this data is lost and replaced with '1
> days' if
> moving forwards or backwards in the agenda with 'f' and 'b' or jumping
> to a date with 'j'.
>
> Otherwise I think this looks good to me.
>
> Regards,
> Bernt
>
>
- Carsten
next prev parent reply other threads:[~2010-12-03 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:49 [PATCH] org-agenda: rework ndays and span handling Julien Danjou
2010-11-29 11:14 ` Carsten Dominik
2010-11-29 11:17 ` Julien Danjou
2010-11-30 23:53 ` Carsten Dominik
2010-12-01 3:59 ` Puneeth
2010-12-01 9:24 ` Julien Danjou
2010-12-01 9:48 ` Puneeth
2010-12-01 10:15 ` Eric S Fraga
2010-12-01 13:09 ` Julien Danjou
2010-12-01 14:09 ` Eric S Fraga
2010-12-03 2:11 ` Bernt Hansen
2010-12-03 8:00 ` Carsten Dominik [this message]
2010-12-03 9:30 ` Julien Danjou
2010-12-03 10:06 ` Carsten Dominik
2010-12-03 11:50 ` Julien Danjou
2010-12-03 12:09 ` [Accepted] " Carsten Dominik
2010-12-06 13:27 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A37FBED4-6D78-4D86-8DA1-3E6CA5867113@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
--cc=julien@danjou.info \
--cc=ucecesf@ucl.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).