From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] org-agenda: rework ndays and span handling Date: Fri, 3 Dec 2010 09:00:53 +0100 Message-ID: References: <1291027797-22612-1-git-send-email-julien@danjou.info> <870C3B1D-3360-4B23-BCEA-DA88715FEF25@gmail.com> <87fwuhwt1p.fsf@pinto.chemeng.ucl.ac.uk> <87mxopiqqi.fsf@keller.adm.naquadah.org> <87fwufhah5.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=59599 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POQZk-0005J3-6G for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 03:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POQZi-0006rp-UV for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 03:01:04 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:42213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POQZi-0006rj-Pr for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 03:01:02 -0500 Received: by eydd26 with SMTP id d26so18574536eyd.0 for ; Fri, 03 Dec 2010 00:01:01 -0800 (PST) In-Reply-To: <87fwufhah5.fsf@gollum.intra.norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: Julien Danjou , Eric S Fraga , emacs-orgmode@gnu.org On Dec 3, 2010, at 3:11 AM, Bernt Hansen wrote: > Julien Danjou writes: > >> On Wed, Dec 01 2010, Eric S Fraga wrote: >> >>> Mostly works fine but there is one problem I have encountered. If >>> you >>> change your view (mine defaults to day so I sometimes switch to week >>> view), you can go forward and backward as expected. However, if you >>> /jump/ (j in agenda view) to a given date, the view resets to the >>> default (well, to single day view in my case). I prefer the view to >>> remain as I have specified it last until I change it myself. >> >> Good catch. Patch updated fixing that. > > Hi Julien, > > I tried your patch out tonight and I'm confused about org-agenda- > ndays. > This is stated as obsolete (since 24.1 ? what's that?) but the default > for org-agenda-span doesn't seem to be set based on the existing value > of org-agenda-ndays. Is that on purpose? > > I'm fine with customizing org-agenda-span as long as it's documented > that this needs to be done for the next version of org-mode that > includes your patch. I guess making org-agenda-ndays should be made an alias for org-agenda- span. > > I also noticed the display on the modeline says 'Day', 'Week', > 'Month', > or 'Year' when displaying the agenda with 'd', 'w', 'v m', and 'v y' > which is great. However this data is lost and replaced with '1 > days' if > moving forwards or backwards in the agenda with 'f' and 'b' or jumping > to a date with 'j'. > > Otherwise I think this looks good to me. > > Regards, > Bernt > > - Carsten