* [BUG] org-latex ignores org-export-latex-hyperref-format?
@ 2010-10-16 10:02 Guy Wiener
2010-10-17 3:29 ` Noorul Islam
0 siblings, 1 reply; 3+ messages in thread
From: Guy Wiener @ 2010-10-16 10:02 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 522 bytes --]
I found the following weird thing in org-latex, and I think it is a bug:
The customization option "org-export-latex-hyperref-format" is suppose to
render links to hyperrefs in the exported tex file. However, in
org-latex.el, lines 1889 and 1892, the string "\\hyperref[%s]{%s}" is
hard-coded, so that the link export format is not really customizable. I
replaced this string with the custom variable and the option works as
expected - I.e., changing the option chanced the format of exported links.
Thanks,
Guy Wiener.
[-- Attachment #1.2: Type: text/html, Size: 613 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [BUG] org-latex ignores org-export-latex-hyperref-format?
2010-10-16 10:02 [BUG] org-latex ignores org-export-latex-hyperref-format? Guy Wiener
@ 2010-10-17 3:29 ` Noorul Islam
2010-10-17 5:40 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Noorul Islam @ 2010-10-17 3:29 UTC (permalink / raw)
To: Guy Wiener; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Sat, Oct 16, 2010 at 3:32 PM, Guy Wiener <wiener.guy@gmail.com> wrote:
> I found the following weird thing in org-latex, and I think it is a bug:
> The customization option "org-export-latex-hyperref-format" is suppose to
> render links to hyperrefs in the exported tex file. However, in
> org-latex.el, lines 1889 and 1892, the string "\\hyperref[%s]{%s}" is
> hard-coded, so that the link export format is not really customizable. I
> replaced this string with the custom variable and the option works as
> expected - I.e., changing the option chanced the format of exported links.
Looks like commit cae0c63c488067e93b665e9110dc74a634c52529 has introduced
new customizable variable org-export-latex-hyperref-format but left
out some places
in the code to be replaced. Attached is the patch.
Log:
* lisp/org-latex.el (org-export-latex-links) : Replaced hard coded
hyperref format with custom
variable `org-export-latex-hyperref-format'
Found by Guy Wiener <wiener.guy@gmail.com>
Thanks and Regards
Noorul
[-- Attachment #2: org-latex2.txt --]
[-- Type: text/plain, Size: 739 bytes --]
diff --git a/lisp/org-latex.el b/lisp/org-latex.el
index 6adfc78..4cbc031 100644
--- a/lisp/org-latex.el
+++ b/lisp/org-latex.el
@@ -2015,10 +2015,10 @@ The conversion is made depending of STRING-BEFORE and STRING-AFTER."
(insert (format
(org-export-get-coderef-format path desc)
(cdr (assoc path org-export-code-refs)))))
- (radiop (insert (format "\\hyperref[%s]{%s}"
+ (radiop (insert (format org-export-latex-hyperref-format
(org-solidify-link-text raw-path) desc)))
((not type)
- (insert (format "\\hyperref[%s]{%s}"
+ (insert (format org-export-latex-hyperref-format
(org-remove-initial-hash
(org-solidify-link-text raw-path))
desc)))
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [BUG] org-latex ignores org-export-latex-hyperref-format?
2010-10-17 3:29 ` Noorul Islam
@ 2010-10-17 5:40 ` Carsten Dominik
0 siblings, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2010-10-17 5:40 UTC (permalink / raw)
To: Noorul Islam; +Cc: Guy Wiener, emacs-orgmode
Applied, thanks.
- Carsten
On Oct 17, 2010, at 5:29 AM, Noorul Islam wrote:
> On Sat, Oct 16, 2010 at 3:32 PM, Guy Wiener <wiener.guy@gmail.com>
> wrote:
>> I found the following weird thing in org-latex, and I think it is a
>> bug:
>> The customization option "org-export-latex-hyperref-format" is
>> suppose to
>> render links to hyperrefs in the exported tex file. However, in
>> org-latex.el, lines 1889 and 1892, the string "\\hyperref[%s]{%s}" is
>> hard-coded, so that the link export format is not really
>> customizable. I
>> replaced this string with the custom variable and the option works as
>> expected - I.e., changing the option chanced the format of exported
>> links.
>
> Looks like commit cae0c63c488067e93b665e9110dc74a634c52529 has
> introduced
> new customizable variable org-export-latex-hyperref-format but left
> out some places
> in the code to be replaced. Attached is the patch.
>
> Log:
>
> * lisp/org-latex.el (org-export-latex-links) : Replaced hard coded
> hyperref format with custom
> variable `org-export-latex-hyperref-format'
>
> Found by Guy Wiener <wiener.guy@gmail.com>
>
> Thanks and Regards
> Noorul
> <org-latex2.txt>_______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-17 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-16 10:02 [BUG] org-latex ignores org-export-latex-hyperref-format? Guy Wiener
2010-10-17 3:29 ` Noorul Islam
2010-10-17 5:40 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).