emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: stardiviner <numbchild@gmail.com>
To: Samuel Loury <konubinix@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: [SOLVED] Re: [QUESTION] Add advice on command org-add-note not working
Date: Fri, 20 Aug 2021 23:16:02 +0800	[thread overview]
Message-ID: <A013B987-3CC2-403B-B4CB-C9C953C466E4@gmail.com> (raw)
In-Reply-To: <87wnogbj2w.fsf@gmail.com>

Thanks Samuel, using `org-store-log-note’ indeed solved the problem. Great solution.


> On Aug 20, 2021, at 4:45 PM, Samuel Loury <konubinix@gmail.com> wrote:
> 
> "Christopher M. Miles" <numbchild@gmail.com> writes:
> 
>> <#secure method=pgpmime mode=sign>
> 
> Beware this did not actually sign your message.
> 
>> I have following advice code:
>> 
>> #+begin_src emacs-lisp
>> (defun my/org-add-note--auto-add-tag ()
>>  "Auto add tag 'LOG' when add note log."
>>  (org-back-to-heading)
>>  ;; DEBUG: the following code is not executed.
>>  (message "DEBUG")
>>  (require 'seq)
>>  (org-set-tags (seq-uniq (cons "LOG" (org-get-tags nil t)))))
>> 
>> (advice-add 'org-add-note :after #'my/org-add-note--auto-add-tag)
>> #+end_src
>> 
>> With Emacs Edebug, I found it only executed to ~(org-back-to-heading)~, then stopped. The following
>> "DEBUG" message is not printed and tag "LOG" is not added.
>> 
>> Does anybody have some clue for this issue?
> 
> `org-add-note` only sets up a side buffer to write the content of the
> note. The "go back to the heading to actually write the note" is done by
> `org-store-log-note`, invoked using C-c C-c on your note.
> 
> So it is normal that `org-back-to-heading` fails in the org-note buffer
> that indeed does not have a heading.
> 
> Hint: press p when in edebug session to find out in which buffer context
> the code will apply.
> 
> I just tried applying the advice to `org-store-log-note` instead of
> `org-add-note` and it worked fine :-).
> 
> My best,
> -- 
> Konubinix
> GPG Key    : 7439106A
> Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A

     prev parent reply	other threads:[~2021-08-20 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  1:22 [QUESTION] Add advice on command org-add-note not working Christopher M. Miles
2021-08-20  8:45 ` Samuel Loury
2021-08-20 15:16   ` stardiviner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A013B987-3CC2-403B-B4CB-C9C953C466E4@gmail.com \
    --to=numbchild@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=konubinix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).