emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Samuel Loury <konubinix@gmail.com>
To: numbchild@gmail.com, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [QUESTION] Add advice on command org-add-note not working
Date: Fri, 20 Aug 2021 10:45:27 +0200	[thread overview]
Message-ID: <87wnogbj2w.fsf@gmail.com> (raw)
In-Reply-To: <PAXPR08MB66405CA0BEB51487EA8EBDF4A3C19@PAXPR08MB6640.eurprd08.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

"Christopher M. Miles" <numbchild@gmail.com> writes:

> <#secure method=pgpmime mode=sign>

Beware this did not actually sign your message.

> I have following advice code:
> #+begin_src emacs-lisp
> (defun my/org-add-note--auto-add-tag ()
>   "Auto add tag 'LOG' when add note log."
>   (org-back-to-heading)
>   ;; DEBUG: the following code is not executed.
>   (message "DEBUG")
>   (require 'seq)
>   (org-set-tags (seq-uniq (cons "LOG" (org-get-tags nil t)))))
> (advice-add 'org-add-note :after #'my/org-add-note--auto-add-tag)
> #+end_src
> With Emacs Edebug, I found it only executed to ~(org-back-to-heading)~, then stopped. The following
> "DEBUG" message is not printed and tag "LOG" is not added.
> Does anybody have some clue for this issue?

`org-add-note` only sets up a side buffer to write the content of the
note. The "go back to the heading to actually write the note" is done by
`org-store-log-note`, invoked using C-c C-c on your note.

So it is normal that `org-back-to-heading` fails in the org-note buffer
that indeed does not have a heading.

Hint: press p when in edebug session to find out in which buffer context
the code will apply.

I just tried applying the advice to `org-store-log-note` instead of
`org-add-note` and it worked fine :-).

My best,
GPG Key    : 7439106A
Fingerprint: 5993 BE7A DA65 E2D9 06CE  5C36 75D2 3CED 7439 106A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2021-08-20  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  1:22 [QUESTION] Add advice on command org-add-note not working Christopher M. Miles
2021-08-20  8:45 ` Samuel Loury [this message]
2021-08-20 15:16   ` [SOLVED] " stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnogbj2w.fsf@gmail.com \
    --to=konubinix@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).