emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Unnecessary comma escapes in HTML export of #+INCLUDE files
Date: Tue, 01 Sep 2009 18:47:51 -0400	[thread overview]
Message-ID: <9119.1251845271@alphaville.usa.hp.com> (raw)
In-Reply-To: Message from Hsiu-Khuern Tang <hsiu-khuern.tang@hp.com> of "Tue, 01 Sep 2009 15:03:13 PDT." <20090901220312.GP4172@hplhtang.hpl.hp.com>

Hsiu-Khuern Tang <hsiu-khuern.tang@hp.com> wrote:

> * On Fri 05:45AM +0000, 24 Jul 2009, Tang, Hsiu-Khuern (hsiu-khuern.tang@hp.com) wrote:
> > * On Fri 01:22AM +0000, 24 Jul 2009, Bastien (bastienguerry@googlemail.com) wrote:
> > > Hi Hsiu-Khuern,
> > > 
> > > I've just pushed a fix for this: when the "src" switch is present,
> > > including a file won't escape org-like lines.  With a bare #+include 
> > > we still escape lines starting with * or #.
> > > 
> > > Please test it and report any problem. 
> > 
> > It works beautifully now.  Thank you very much for the fix!
> 
> It looks Org has reverted to the old behavior: inserting a comma at a beginning
> of every line in the #INCLUDE'd file that starts with whitespace followed by #.
> 
> For example, if you export this as ascii (see
> http://article.gmane.org/gmane.emacs.orgmode/15718):
> 
> File 1: a.org
> ==================================================
> * test
> 
> #+INCLUDE: "a.sh" src sh
> ==================================================
> 
> File 2: a.sh
> ==================================================
> #!/bin/sh
> 
>  ## shell comment
> echo "This is a test"
> ==================================================
> 
> the output contains the line ", ## shell comment".
> 
> Related question: what git commands does one use to obtain all the commits that
> changed a particular range of lines in a file?  I'm quite lost with git.
> 

There was some churn for this particular functionality, but since I
don't really understand what is *supposed* to happen, I'll just refer
you (and Carsten and Bastien, both of whom made -possibly conflicting-
changes to this functionality) to the following exchange in the archive,
hoping it will shed some light and lead to a satisfactory resolution for
all involved:

   http://thread.gmane.org/gmane.emacs.orgmode/16244/focus=16259


The relevant commits are

    68b65e8f480c17cfe1024001c236eb4065893f4d

and

    dfd3749a273cc9f9a1d954363ea6de87049d17a7

Thanks,
Nick

  parent reply	other threads:[~2009-09-01 22:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  1:13 Unnecessary comma escapes in HTML export of #+INCLUDE files Tang, Hsiu-Khuern
2009-07-22  7:50 ` Bastien
2009-07-22 17:35   ` Hsiu-Khuern Tang
2009-07-24  1:22     ` Bastien
2009-07-24  5:45       ` Hsiu-Khuern Tang
2009-09-01 22:03         ` Hsiu-Khuern Tang
     [not found]           ` <hsiu-khuern.tang@hp.com>
2009-09-01 22:47             ` Nick Dokos [this message]
2009-09-02  0:09               ` Hsiu-Khuern Tang
2009-09-02  6:25           ` Carsten Dominik
2009-09-02  7:40             ` Nick Dokos
2009-09-02  9:33               ` Carsten Dominik
2009-09-03  5:34                 ` Hsiu-Khuern Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9119.1251845271@alphaville.usa.hp.com \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).