Re: Unnecessary comma escapes in HTML export of #+INCLUDE files

From: Carsten Dominik <carsten.dominik@gmail.com>
To: nicholas.dokos@hp.com
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Unnecessary comma escapes in HTML export of #+INCLUDE files
Date: Wed, 2 Sep 2009 11:33:46 +0200	[thread overview]
Message-ID: <1B3BC392-A83A-46DF-8B0F-6C475D060477@gmail.com> (raw)
In-Reply-To: <16221.1251877255@gamaville.dokosmarshall.org>

Ah, yes, thank you for that detail.

Fixed now.

- Carsten

On Sep 2, 2009, at 9:40 AM, Nick Dokos wrote:

> Carsten Dominik <carsten.dominik@gmail.com> wrote:
>
>> I am not able to reproduce the problem.
>>
>
> If the comment in a.sh starts with a space like this:
>
> ,----
> | #!/bin/sh
> |
> |  ## shell comment
> | echo "This is a test"
> `----
>
> then the .txt file has a comma before the comment:
>
> ,----
> | ...
> | 1 test
> | ~~~~~~~
> |
> |   #!/bin/sh
> |
> |   , ## shell comment
> |   echo "This is a test"
> `----
>
> If there is no space, then the comma is not present.  I'm really not
> sure how this is supposed to work - is that the intention?
>
> Thanks,
> Nick
>
> Versions: GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version  
> 2.12.9) of 2009-08-09 on gamaville.dokosmarshall.org
>          Org-mode version 6.30 (release_6.30.8.g8b6ff)
> (that includes my local changes, but nothing relating to this  
> problem).
>
> Carsten Dominik <carsten.dominik@gmail.com> wrote:
>
>> Hi Hsiu-Khuern,
>>
>> I am not able to reproduce the problem.
>>
>> - Carsten
>>
>> On Sep 2, 2009, at 12:03 AM, Hsiu-Khuern Tang wrote:
>>
>>> * On Fri 05:45AM +0000, 24 Jul 2009, Tang, Hsiu-Khuern (hsiu-khuern.tang@hp.com
>>> ) wrote:
>>>> * On Fri 01:22AM +0000, 24 Jul 2009, Bastien (bastienguerry@googlemail.com
>>>> ) wrote:
>>>>> Hi Hsiu-Khuern,
>>>>>
>>>>> I've just pushed a fix for this: when the "src" switch is present,
>>>>> including a file won't escape org-like lines.  With a bare # 
>>>>> +include
>>>>> we still escape lines starting with * or #.
>>>>>
>>>>> Please test it and report any problem.
>>>>
>>>> It works beautifully now.  Thank you very much for the fix!
>>>
>>> It looks Org has reverted to the old behavior: inserting a comma at
>>> a beginning
>>> of every line in the #INCLUDE'd file that starts with whitespace
>>> followed by #.
>>>
>>> For example, if you export this as ascii (see
>>> http://article.gmane.org/gmane.emacs.orgmode/15718):
>>>
>>> File 1: a.org
>>> ==================================================
>>> * test
>>>
>>> #+INCLUDE: "a.sh" src sh
>>> ==================================================
>>>
>>> File 2: a.sh
>>> ==================================================
>>> #!/bin/sh
>>>
>>> ## shell comment
>>> echo "This is a test"
>>> ==================================================
>>>
>>> the output contains the line ", ## shell comment".
>>>
>>> Related question: what git commands does one use to obtain all the
>>> commits that
>>> changed a particular range of lines in a file?  I'm quite lost with
>>> git.
>>>
>>> -- 
>>> Best,
>>> Hsiu-Khuern.
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>