From: Mario Martelli <tlmtr@schnuddelhuddel.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-protocol documentation
Date: Fri, 23 Jun 2017 09:50:10 +0200 [thread overview]
Message-ID: <8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de> (raw)
In-Reply-To: <87efub7psj.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
Hi,
> Am 22.06.2017 um 22:03 schrieb Nicolas Goaziou <mail@nicolasgoaziou.fr>:
>
> So as to ease the reviewing process, could you send it on the ML with
> git format-patch sub-command?
>
sure. I would like to add an example using the subprotocol “open-source” for hugo. If that sounds ok for you.
For that I would need “open-source” working, of course.
> Also, I suggest using ox-texinfo from development version, if you can,
> as the Texinfo output should be superior.
have to set that up first. But I think I will need it anyway. ;)
>>> I assume a bug around Line 527 in org-protocol.el
>>>
>>> (let* ((base-url (plist-get (cdr prolist) :base-url))
>>> —> (wsearch (regexp-quote base-url))) <—
>>>
>>> Could anyone confirm that? I’m unsure whether it might be a local misconfiguration on my side or not.
>
> Confirm what?
That “open-source" is not working and is failing silently.
> Why do you think there is a bug in the line above?
Because I’m not experienced with elisp ;)
I dug a little deeper and do now assume that there *might* be something wrong with “f” which is created in line 523
(f (plist-get (org-protocol-parse-parameters fname nil '(:url)) :url)))
and which has “http:” as value if I’m using old style URIs and the whole URL (“http:/orgmode.org/worg/org-tutorials/org-import-rtm.html <http://orgmode.org/worg/org-tutorials/org-import-rtm.html>” in my example) if I’m using new style URIs.
I assume “f” should be set to the base-url ("http:/orgmode.org/worg/ <http://orgmode.org/worg/>“ in my case).
Given that, the test in line 529
(when (string-match wsearch f)
fails all the time causing the function to fail silently.
Thank you for being patient with me. At the moment I’m seeing parenthesises and backslashes everywhere :)
Kind regards
Mario
—
[-- Attachment #2: Type: text/html, Size: 3593 bytes --]
next prev parent reply other threads:[~2017-06-23 7:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 10:14 org-protocol documentation Mario Martelli
2017-06-19 10:41 ` Nicolas Goaziou
2017-06-19 12:37 ` Mario Martelli
2017-06-19 13:41 ` Chunyang Xu
2017-06-21 17:29 ` Nicolas Goaziou
2017-06-21 18:58 ` Mario Martelli
2017-06-21 19:12 ` Nicolas Goaziou
2017-06-22 8:40 ` Mario Martelli
2017-06-22 19:32 ` Mario Martelli
2017-06-22 20:03 ` Nicolas Goaziou
2017-06-23 7:50 ` Mario Martelli [this message]
2017-06-23 16:46 ` Mario Martelli
2017-06-25 6:49 ` [PATCH] org-protocol: fixes open-source and extends rewriting of URLs Mario Martelli
2017-06-25 7:17 ` Nicolas Goaziou
2017-06-25 8:21 ` Mario Martelli
2017-06-26 20:46 ` Nicolas Goaziou
2017-06-27 6:54 ` Mario Martelli
2017-06-28 9:32 ` Nicolas Goaziou
2017-06-28 14:44 ` Mario Martelli
2017-06-28 15:49 ` Nicolas Goaziou
2017-06-29 8:28 ` Mario Martelli
2017-06-29 12:47 ` Nicolas Goaziou
2017-06-25 10:15 ` org-protocol documentation Mario Martelli
2017-06-29 12:42 ` Nicolas Goaziou
2017-06-29 18:30 ` Mario Martelli
2017-06-30 12:05 ` Mario Martelli
2017-07-01 10:34 ` Nicolas Goaziou
2017-07-01 13:13 ` Mario Martelli
2017-07-01 16:42 ` Nicolas Goaziou
2017-07-01 16:44 ` Nicolas Goaziou
2017-07-01 19:24 ` Mario Martelli
2017-07-03 17:21 ` Nick Dokos
2017-07-03 18:09 ` Mario Martelli
2017-07-06 17:54 ` Nicolas Goaziou
2017-07-23 16:18 ` Mario Martelli
2017-07-23 20:49 ` Nicolas Goaziou
2017-07-23 22:39 ` Adam Porter
2017-07-24 6:17 ` Colin Baxter
2017-07-24 23:53 ` Adam Porter
2017-07-25 8:13 ` Colin Baxter
2017-06-30 4:42 ` Mario Martelli
2017-06-19 12:26 ` Chunyang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de \
--to=tlmtr@schnuddelhuddel.de \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).