From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Mario Martelli <tlmtr@schnuddelhuddel.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-protocol: fixes open-source and extends rewriting of URLs
Date: Wed, 28 Jun 2017 11:32:50 +0200 [thread overview]
Message-ID: <87injgh2yl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <92533F36-7529-496B-BA7B-8ED49FBFB3D2@schnuddelhuddel.de> (Mario Martelli's message of "Tue, 27 Jun 2017 08:54:08 +0200")
Hello,
Mario Martelli <tlmtr@schnuddelhuddel.de> writes:
> Sorry for producing noise. Just read the contribution guidelines once again ;)
> Hope everything is now according to the guidelines.
Thank you. Comments follow.
> Subject: [PATCH 1/4] org-protocol.el: Fix for failing open-source subprotocol
>
> * (org-protocol-open-source): make sure url is
> sanitised before processing
Applied.
> Subject: [PATCH 2/4] org-protocol.el: Fix for silently failing open-source
> subprotocol
>
> * (org-protocol-open-source): tests URL against
> base-url and not the filename
Applied.
> Subject: [PATCH 3/4] org-protocol.el sources with date URL are supported
>
> * (org-protocol-project-alist): date-URL is added as example
> * (org-protocol-open-source): first match is processed in rewrite
Not applied. See below.
> + :rewrites ((\"org/?$\" . \"index.php\")))
> + (\"Hugo based blog\"
> + :base-url \"https://themes.gohugo.io/theme/hugo-icarus/\"
> + :working-directory \"~/Documents/MyBlog/themes/hugo-icarus-theme/exampleSite/content/post/\"
> + :online-suffix \".html\"
> + :working-suffix \".md\"
> + :rewrites ((\"\\(https://themes.gohugo.io/theme/hugo-icarus/[0-9]+/[0-9]+/[0-9]+/\\)\" . \".md\")))))
Would it be possible to make the path involved smaller so that the
example can fit in 80 columns?
> The last line tells `org-protocol-open-source' to open
> /home/user/org/index.php, if the URL cannot be mapped to an existing
> @@ -554,8 +561,13 @@ The location for a browser's bookmark should look like this:
> ;; Try to match a rewritten URL and map it to
> ;; a real file. Compare redirects without
> ;; suffix.
> - (when (string-match-p (car rewrite) f1)
> - (throw 'result (concat wdir (cdr rewrite))))))))
> + (when (string-match (car rewrite) f1)
> + (setq replacement (cdr rewrite))
Here, `replacement' isn't lexically bound, so compiling
"org-protocol.el" should return an error. `replacement' should be
let-bound instead.
> + (if (match-string 0 f1)
AFAIU, (match-string 0 f1) is necessarily true, per the (string-match
(car rewrite) f1) above, so the test can be removed.
> + (setq replacement (concat
> + (directory-file-name (replace-match "" nil nil f1 1))
> + replacement )))))
Spurious white space character before the parenthesis.
> + (throw 'result (concat wdir replacement)))))
Shouldn't the (throw ...) be within the (when (string-match ...)) as it
was before? I may be wrong. I didn't check the high level logic of the
patch since I don't know "org-protocol.el".
> Applied for it just now. Have marked the changes as tiny.
Great. Let me know when the process is complete.
Regards,
--
Nicolas Goaziou 0x80A93738
next prev parent reply other threads:[~2017-06-28 9:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 10:14 org-protocol documentation Mario Martelli
2017-06-19 10:41 ` Nicolas Goaziou
2017-06-19 12:37 ` Mario Martelli
2017-06-19 13:41 ` Chunyang Xu
2017-06-21 17:29 ` Nicolas Goaziou
2017-06-21 18:58 ` Mario Martelli
2017-06-21 19:12 ` Nicolas Goaziou
2017-06-22 8:40 ` Mario Martelli
2017-06-22 19:32 ` Mario Martelli
2017-06-22 20:03 ` Nicolas Goaziou
2017-06-23 7:50 ` Mario Martelli
2017-06-23 16:46 ` Mario Martelli
2017-06-25 6:49 ` [PATCH] org-protocol: fixes open-source and extends rewriting of URLs Mario Martelli
2017-06-25 7:17 ` Nicolas Goaziou
2017-06-25 8:21 ` Mario Martelli
2017-06-26 20:46 ` Nicolas Goaziou
2017-06-27 6:54 ` Mario Martelli
2017-06-28 9:32 ` Nicolas Goaziou [this message]
2017-06-28 14:44 ` Mario Martelli
2017-06-28 15:49 ` Nicolas Goaziou
2017-06-29 8:28 ` Mario Martelli
2017-06-29 12:47 ` Nicolas Goaziou
2017-06-25 10:15 ` org-protocol documentation Mario Martelli
2017-06-29 12:42 ` Nicolas Goaziou
2017-06-29 18:30 ` Mario Martelli
2017-06-30 12:05 ` Mario Martelli
2017-07-01 10:34 ` Nicolas Goaziou
2017-07-01 13:13 ` Mario Martelli
2017-07-01 16:42 ` Nicolas Goaziou
2017-07-01 16:44 ` Nicolas Goaziou
2017-07-01 19:24 ` Mario Martelli
2017-07-03 17:21 ` Nick Dokos
2017-07-03 18:09 ` Mario Martelli
2017-07-06 17:54 ` Nicolas Goaziou
2017-07-23 16:18 ` Mario Martelli
2017-07-23 20:49 ` Nicolas Goaziou
2017-07-23 22:39 ` Adam Porter
2017-07-24 6:17 ` Colin Baxter
2017-07-24 23:53 ` Adam Porter
2017-07-25 8:13 ` Colin Baxter
2017-06-30 4:42 ` Mario Martelli
2017-06-19 12:26 ` Chunyang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87injgh2yl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=tlmtr@schnuddelhuddel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).