* Buguette in `org-context'
@ 2009-10-01 16:33 Michael Sperber
2009-10-01 18:03 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Sperber @ 2009-10-01 16:33 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
`org-context' fails if called at the beginning of a buffer. I think the
reason is a call to `eobp' that wants to be a call to `bobp'.
This buguette actually has serious consequences at least on XEmacs:
`org-context' is called off the menubar construction, and if that fails,
XEmacs crashes.
(Try typing C-c C-s at the very beginning of an org-mode buffer.)
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
[-- Attachment #2: Type: text/plain, Size: 883 bytes --]
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 25be313..c3db38c 100755
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2009-10-01 Mike Sperber <mike@xemacs.org>
+
+ * org.el (org-context): Replace an (eobp) by (bobp) that was
+ probably intended.
+
2009-09-28 Carsten Dominik <carsten.dominik@gmail.com>
* org.el (org-ctrl-c-ctrl-c): Pass prefix arg to
diff --git a/lisp/org.el b/lisp/org.el
index bde12b1..cc3a5e1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16007,7 +16007,7 @@ and :keyword."
(push (org-point-in-group p 2 :todo-keyword) clist)
(push (org-point-in-group p 4 :tags) clist))
(goto-char p)
- (skip-chars-backward "^[\n\r \t") (or (eobp) (backward-char 1))
+ (skip-chars-backward "^[\n\r \t") (or (bobp) (backward-char 1))
(if (looking-at "\\[#[A-Z0-9]\\]")
(push (org-point-in-group p 0 :priority) clist)))
[-- Attachment #3: Type: text/plain, Size: 204 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Buguette in `org-context'
2009-10-01 16:33 Buguette in `org-context' Michael Sperber
@ 2009-10-01 18:03 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2009-10-01 18:03 UTC (permalink / raw)
To: Michael Sperber; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On Oct 1, 2009, at 6:33 PM, Michael Sperber wrote:
>
> `org-context' fails if called at the beginning of a buffer. I think
> the
> reason is a call to `eobp' that wants to be a call to `bobp'.
>
> This buguette actually has serious consequences at least on XEmacs:
> `org-context' is called off the menubar construction, and if that
> fails,
> XEmacs crashes.
>
> (Try typing C-c C-s at the very beginning of an org-mode buffer.)
>
> --
> Cheers =8-} Mike
> Friede, Völkerverständigung und überhaupt blabla
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 25be313..c3db38c 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,8 @@
> +2009-10-01 Mike Sperber <mike@xemacs.org>
> +
> + * org.el (org-context): Replace an (eobp) by (bobp) that was
> + probably intended.
> +
> 2009-09-28 Carsten Dominik <carsten.dominik@gmail.com>
>
> * org.el (org-ctrl-c-ctrl-c): Pass prefix arg to
> diff --git a/lisp/org.el b/lisp/org.el
> index bde12b1..cc3a5e1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16007,7 +16007,7 @@ and :keyword."
> (push (org-point-in-group p 2 :todo-keyword) clist)
> (push (org-point-in-group p 4 :tags) clist))
> (goto-char p)
> - (skip-chars-backward "^[\n\r \t") (or (eobp) (backward-char 1))
> + (skip-chars-backward "^[\n\r \t") (or (bobp) (backward-char 1))
> (if (looking-at "\\[#[A-Z0-9]\\]")
> (push (org-point-in-group p 0 :priority) clist)))
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-01 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-01 16:33 Buguette in `org-context' Michael Sperber
2009-10-01 18:03 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).