From: Bake Timmons <b3timmons@speedymail.org>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH]: Fix to spreadsheet ranges in A1 style
Date: Mon, 20 Aug 2007 09:42:13 -0400 [thread overview]
Message-ID: <87zm0miaq2.fsf@freed.localdomain> (raw)
Carsten Dominik <dominik@science.uva.nl> writes:
> On Aug 20, 2007, at 4:46, Bake Timmons wrote:
>> (concat "[" (mapconcat
>> (lambda (x)
>> @@ -9131,8 +9132,11 @@
>> ((match-end 3)
>> ;; format match, just advance
>> (setq start (match-end 0)))
>> - ((and (> (match-beginning 0) 0)
>> - (equal ?. (aref s (max (1- (match-beginning 0)) 0))))
>> + ((let ((pos (match-beginning 0)))
>> + (and (> pos 0)
>> + (equal ?. (aref s (1- pos)))
>> + ;; not using .. for a range reference
>> + (or (< pos 2) (not (equal ?. (aref s (1- pos)))))))
>> ;; 3.e5 or something like this. FIXME: is this ok????
>> (setq start (match-end 0)))
>> (t
>
> Could you please explain this part of the patch to me?
> Thanks.
After fixing the mapconcat bug, I reloaded the code and observed an
erroneous conversion of a range in an elisp formula. E.g., during
formula debugging A1..B1 becomes @1$1..B1 instead of @1$1..@1$2. More
debugging showed that A1 match correctly takes the final branch of the
cond within the org-table-convert-refs-to-rc function and is
converted, but that the match for B1 erroneously matched the second
condition of the cond form, i.e., it is treated as something in
scientific notation and is incorrectly skipped over. Thus, I changed
the test to ensure that no additional "." is adjacent to the already
recognized ".". Moreover, I eliminated the max function call, since a
positive number minus one is already nonnegative. Thanks.
next reply other threads:[~2007-08-20 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 13:42 Bake Timmons [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-20 2:46 [PATCH]: Fix to spreadsheet ranges in A1 style Bake Timmons
2007-08-20 5:42 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zm0miaq2.fsf@freed.localdomain \
--to=b3timmons@speedymail.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).