emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bake Timmons <b3timmons@speedymail.org>
To: emacs-orgmode@gnu.org
Subject: [PATCH]: Fix to spreadsheet ranges in A1 style
Date: Sun, 19 Aug 2007 22:46:01 -0400	[thread overview]
Message-ID: <871wdyq5xy.fsf@freed.localdomain> (raw)

A simple elisp formula in the spreadsheet indicated a couple of errors
in the handling of ranges:

'(car '(A4..C4))

This was using org.el from the latest Emacs cvs MAIN branch.  I have
appended a patch against this as one possible fix.  Thanks.

--- src/emacs/lisp/textmodes/org.el	2007-08-18 20:37:11.000000000 -0400
+++ build/emacs/lisp/textmodes/org.el	2007-08-19 22:27:06.000000000 -0400
@@ -8839,6 +8839,7 @@
 	   (if (eq lispp 'literal)
 	       x
 	     (prin1-to-string (if numbers (string-to-number x) x))))
+	 elements
 	 " ")
       (concat "[" (mapconcat
 		   (lambda (x)
@@ -9131,8 +9132,11 @@
        ((match-end 3)
 	;; format match, just advance
 	(setq start (match-end 0)))
-       ((and (> (match-beginning 0) 0)
-	     (equal ?. (aref s (max (1- (match-beginning 0)) 0))))
+       ((let ((pos (match-beginning 0)))
+	  (and (> pos 0)
+	       (equal ?. (aref s (1- pos)))
+	       ;; not using .. for a range reference
+	       (or (< pos 2) (not (equal ?. (aref s (1- pos)))))))
 	;; 3.e5 or something like this.  FIXME: is this ok????
 	(setq start (match-end 0)))
        (t

             reply	other threads:[~2007-08-20  2:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20  2:46 Bake Timmons [this message]
2007-08-20  5:42 ` [PATCH]: Fix to spreadsheet ranges in A1 style Carsten Dominik
  -- strict thread matches above, loose matches on Subject: below --
2007-08-20 13:42 Bake Timmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871wdyq5xy.fsf@freed.localdomain \
    --to=b3timmons@speedymail.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).