emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bastien.guerry@wikimedia.fr>
To: Memnon Anon <gegendosenfleisch@googlemail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Setting org-agenda-time-grid: My day starts at midnight
Date: Thu, 02 Sep 2010 15:22:46 +0200	[thread overview]
Message-ID: <87zkw01dqw.fsf@gnu.org> (raw)
In-Reply-To: <874oerjgef.fsf@mean.albasani.net> (Memnon Anon's message of "Thu, 19 Aug 2010 08:17:38 +0200")

Memnon Anon <gegendosenfleisch@googlemail.com> writes:

> I added one line:
>           (unless (and remove (member time have))
>             (setq time (int-to-string time))
> ;;MAN make sure time is at least 3 characters long or substring will fail
> =>          (when (< (length time) 3) (setq time (concat "00" time)))  
>             (push (org-format-agenda-item

Thanks for the report.

I fixed this in a slightly different way:

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 3f66725..90c6935 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5118,7 +5118,7 @@ The modified list may contain inherited tags, and tags matched by
 	  (throw 'exit list))
       (while (setq time (pop gridtimes))
 	(unless (and remove (member time have))
-	  (setq time (int-to-string time))
+	  (setq time (format "%2d" time))
 	  (push (org-format-agenda-item
 		 nil string "" nil
 		 (concat (substring time 0 -2) ":" (substring time -2)))

-- 
 Bastien

next prev parent reply	other threads:[~2010-09-02 13:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  6:17 Setting org-agenda-time-grid: My day starts at midnight Memnon Anon
2010-08-22 10:25 ` [Bug] : org-agenda-time-grid (was: Setting org-agenda-time-grid: My day starts at midnight) Memnon Anon
2010-09-02 13:22 ` Bastien [this message]
2010-09-02 15:05   ` Setting org-agenda-time-grid: My day starts at midnight Memnon Anon
2010-09-02 15:48     ` Bastien
2010-09-02 17:02       ` Memnon Anon
2010-09-05 14:59       ` Memnon Anon
2010-09-05 19:10         ` Bastien
2010-09-05 19:57           ` [Squashed] (was: Setting org-agenda-time-grid: My day starts at midnight) Memnon Anon

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:3f66725 dfblob:90c6935
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zkw01dqw.fsf@gnu.org \
    --to=bastien.guerry@wikimedia.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=gegendosenfleisch@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).