emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Memnon Anon <gegendosenfleisch@googlemail.com>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Setting org-agenda-time-grid: My day starts at midnight
Date: Thu, 19 Aug 2010 08:17:38 +0200	[thread overview]
Message-ID: <874oerjgef.fsf@mean.albasani.net> (raw)

Hi,

I am working nightshifts these days, so I wanted this:

,----
| (setq org-agenda-time-grid (quote 
|       ((daily weekly today require-timed) "----------------" 
|       ( 000 200 400 600 800 1000 1200 1400 1600 1800 2000 2200 2359))))
`----

which ... did not work.

Afaics, the reason is in org-agenda-add-time-grid-maybe:

--8<---------------cut here---------------start------------->8---
      (while (setq time (pop gridtimes))
	(unless (and remove (member time have))
=>	  (setq time (int-to-string time))
	  (push (org-format-agenda-item
		 nil string "" nil
=>		 (concat (substring time 0 -2) ":" (substring time -2)))
		new)
	  (put-text-property
	   1 (length (car new)) 'face 'org-time-grid (car new))))
--8<---------------cut here---------------end--------------->8---

(setq time (int-to-string time)) => time= "0", so
(substring time 0 -2) => args-out-of-range.

I added one line:
--8<---------------cut here---------------start------------->8---
          (unless (and remove (member time have))
            (setq time (int-to-string time))
;;MAN make sure time is at least 3 characters long or substring will fail
=>          (when (< (length time) 3) (setq time (concat "00" time)))  
            (push (org-format-agenda-item
--8<---------------cut here---------------end--------------->8---

and it seems to work: I used it for the last hours and found no problem.

So you elisp gurus out there:

a) Will this break anything I am not aware of yet?
b) Is there a better way to achieve this?

Memnon 'Rock around the clock' Anon

next             reply	other threads:[~2010-08-19  6:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  6:17 Memnon Anon [this message]
2010-08-22 10:25 ` [Bug] : org-agenda-time-grid (was: Setting org-agenda-time-grid: My day starts at midnight) Memnon Anon
2010-09-02 13:22 ` Setting org-agenda-time-grid: My day starts at midnight Bastien
2010-09-02 15:05   ` Memnon Anon
2010-09-02 15:48     ` Bastien
2010-09-02 17:02       ` Memnon Anon
2010-09-05 14:59       ` Memnon Anon
2010-09-05 19:10         ` Bastien
2010-09-05 19:57           ` [Squashed] (was: Setting org-agenda-time-grid: My day starts at midnight) Memnon Anon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874oerjgef.fsf@mean.albasani.net \
    --to=gegendosenfleisch@googlemail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).