emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-babel-parse-src-block-match params parse bug
@ 2012-05-16  9:30 Karl Berg
  2012-05-16 17:16 ` Eric Schulte
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Berg @ 2012-05-16  9:30 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]


Hi, 

Seems like the org-babel-parse-src-block-match function does something
wrong when parsing the block parameters. In my case I am trying to use the :file param with plantuml but it does not get down to the execute function.
To me it seems like the (string-match "-i\\>" switches) call messes up the (match-string
4) call further down.

Attaching a patch
Best regards,
Karl Berg 		 	   		  

[-- Attachment #2: org-babel.patch --]
[-- Type: application/octet-stream, Size: 798 bytes --]

--- ob.el.orig	2012-05-16 11:15:25.000000000 +0200
+++ ob.el	2012-05-16 11:14:58.000000000 +0200
@@ -1148,6 +1148,7 @@
 	 (lang (org-babel-clean-text-properties (match-string 2)))
          (lang-headers (intern (concat "org-babel-default-header-args:" lang)))
 	 (switches (match-string 3))
+     (params (match-string 4))
          (body (org-babel-clean-text-properties
 		(let* ((body (match-string 5))
 		       (sub-length (- (length body) 1)))
@@ -1169,7 +1170,7 @@
            (org-babel-params-from-properties lang)
 	   (if (boundp lang-headers) (eval lang-headers) nil)
 	   (org-babel-parse-header-arguments
-            (org-babel-clean-text-properties (or (match-string 4) ""))))
+            (org-babel-clean-text-properties (or params ""))))
 	  switches
 	  block-indentation)))
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: org-babel-parse-src-block-match params parse bug
  2012-05-16  9:30 org-babel-parse-src-block-match params parse bug Karl Berg
@ 2012-05-16 17:16 ` Eric Schulte
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Schulte @ 2012-05-16 17:16 UTC (permalink / raw)
  To: Karl Berg; +Cc: emacs-orgmode

Karl Berg <kalle465@hotmail.com> writes:

> Hi, 
>
> Seems like the org-babel-parse-src-block-match function does something
> wrong when parsing the block parameters. In my case I am trying to use the :file param with plantuml but it does not get down to the execute function.
> To me it seems like the (string-match "-i\\>" switches) call messes up the (match-string
> 4) call further down.
>
> Attaching a patch
> Best regards,
> Karl Berg 		 	   		  
>

Please ignore my previous request.  I've just pushed up a fix for this
issue.  Please let me know if the problem persists, and thanks for
pointing this out.

Best,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-16 19:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-16  9:30 org-babel-parse-src-block-match params parse bug Karl Berg
2012-05-16 17:16 ` Eric Schulte

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).