From: Feng Shu <tumashu@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: RFQ - new contribution - org-screenshot.el
Date: Fri, 17 May 2013 21:17:21 +0800 [thread overview]
Message-ID: <87zjvt925a.fsf@news.tumashu-localhost.org> (raw)
In-Reply-To: <87li7d99db.wl%max@openchat.com> (Max Mikhanosha's message of "Fri, 17 May 2013 06:41:20 -0400")
Max Mikhanosha <max@openchat.com> writes:
> At Fri, 17 May 2013 09:38:29 +0200,
> Rainer M. Krug wrote:
>>
>> Nice and very useful. Can this be included in /contrib?
>
> That is my intention, I have the FSF paper signed for Emacs and Org.
>
> So what I'm looking for some minimum amount of eyes on the code, and
> advice as to minimum set of things I need to adjust before committing it?
>
> My list is.
>
> 1. Convert defvar to defcustom
>
> 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
> dired.el
>
> 3. The prefix C-c M-s seems awkward but Org is so big everything else
> is taken, and C-c C-x s is too close to C-c C-x C-s, which is
> archive subtree (I initially had it there and moved after archiving
> subtree by mistake)
May be you shoule bind it to a mouse button! :-)
>
> Its its fine to go in as is, then its fine too, I'm pretty lazy :-)
>
> Regards,
> Max
--
next prev parent reply other threads:[~2013-05-17 13:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 3:21 RFQ - new contribution - org-screenshot.el Max Mikhanosha
2013-05-17 6:13 ` Bastien
2013-05-17 7:38 ` Rainer M. Krug
2013-05-17 10:41 ` Max Mikhanosha
2013-05-17 12:33 ` Daniel F
2013-05-17 13:17 ` Feng Shu [this message]
2013-05-17 13:49 ` Bastien
2013-05-17 10:46 ` Carsten Dominik
2013-05-17 13:05 ` Carsten Dominik
2013-05-17 14:37 ` Max Mikhanosha
2013-05-17 13:27 ` Feng Shu
2013-05-17 16:25 ` Max Mikhanosha
2013-05-17 17:20 ` Brett Viren
2013-05-17 18:33 ` Max Mikhanosha
2013-05-17 19:42 ` Brett Viren
2013-05-20 16:53 ` François Pinard
2013-05-20 18:45 ` Russell Adams
2013-05-21 0:14 ` Max Mikhanosha
2013-05-21 0:58 ` Russell Adams
2013-05-21 12:03 ` François Pinard
2013-05-21 12:45 ` Russell Adams
2013-05-21 13:42 ` Haider Rizvi
2013-05-21 15:36 ` Feng Shu
2013-05-21 16:16 ` François Pinard
2013-05-21 17:40 ` Viktor Rosenfeld
2013-05-21 17:42 ` Viktor Rosenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjvt925a.fsf@news.tumashu-localhost.org \
--to=tumashu@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).