From mboxrd@z Thu Jan  1 00:00:00 1970
From: Feng Shu <tumashu@gmail.com>
Subject: Re: RFQ - new contribution - org-screenshot.el
Date: Fri, 17 May 2013 21:17:21 +0800
Message-ID: <87zjvt925a.fsf@news.tumashu-localhost.org>
References: <87mwru8f57.wl%max@openchat.com> <874ne23zir.fsf@bzg.ath.cx>
	<87ppwqawei.fsf@krugs.de> <87li7d99db.wl%max@openchat.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:42876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UdKY6-0002bW-U6
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:18:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UdKY2-0002Nz-1V
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:18:18 -0400
Received: from mail-pd0-f172.google.com ([209.85.192.172]:64737)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@gmail.com>) id 1UdKY1-0002Nm-S6
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:18:13 -0400
Received: by mail-pd0-f172.google.com with SMTP id 6so3341830pdd.3
	for <emacs-orgmode@gnu.org>; Fri, 17 May 2013 06:18:12 -0700 (PDT)
Received: from tumashu ([110.97.92.123]) by mx.google.com with ESMTPSA id
	gh9sm11200348pbc.37.2013.05.17.06.18.10 for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Fri, 17 May 2013 06:18:12 -0700 (PDT)
Received: from feng by tumashu with local (Exim 4.80)
	(envelope-from <tumashu@gmail.com>) id 1UdKXB-0004pz-Kk
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 21:17:21 +0800
In-Reply-To: <87li7d99db.wl%max@openchat.com> (Max Mikhanosha's message of
	"Fri, 17 May 2013 06:41:20 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Max Mikhanosha <max@openchat.com> writes:

> At Fri, 17 May 2013 09:38:29 +0200,
> Rainer M. Krug wrote:
>> 
>> Nice and very useful. Can this be included in /contrib?
>
> That is my intention, I have the FSF paper signed for Emacs and Org.
>
> So what I'm looking for some minimum amount of eyes on the code, and
> advice as to minimum set of things I need to adjust before committing it?
>
> My list is.
>
> 1. Convert defvar to defcustom
>
> 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
>    dired.el
>
> 3. The prefix C-c M-s seems awkward but Org is so big everything else
>    is taken, and C-c C-x s is too close to C-c C-x C-s, which is
>    archive subtree (I initially had it there and moved after archiving
>    subtree by mistake)

May be you shoule bind it to a mouse button! :-)

>
> Its its fine to go in as is, then its fine too, I'm pretty lazy :-)
>
> Regards,
>   Max

--