From: Rasmus <rasmus@gmx.us>
To: listuser36@gmail.com
Cc: emacs-orgmode@gnu.org, alan.schmitt@polytechnique.org,
n.goaziou@gmail.com
Subject: Re: [patch] ox-koma-letter.el: credit [3/4]
Date: Tue, 21 May 2013 19:35:57 +0200 [thread overview]
Message-ID: <87zjvo9qwy.fsf@pank.eu> (raw)
In-Reply-To: <20130521165658.GA56408@client199-78.wlan.hu-berlin.de> (Viktor Rosenfeld's message of "Tue, 21 May 2013 18:56:58 +0200")
Viktor,
Good to hear from you!
>> This is probably the most fun change. It adds special tags PS, ENCL,
>> CC, AFTER_CLOSING as in my last patch set, but it uses heading this
>> time. E.g. ENCLs are under the heading * ENCL :ENCL:. This was
>> suggested by Nicolas, and it's nicer. The ideas comes from
>> ox-groff.el file ¹. Thanks Luis!
>
> This is great! A few things:
>
> - It doesn't work because `org-koma-letter-special-content' is set to
> nil at the beginning of `org-koma-letter-template'. Why is that? If I
> comment it out everything works.
Hmm, it should be populated by the headline function each time. . .
That is at least the idea. I.e.
- When exporting `org-koma-letter-special-content' gets populated
and is available until next export.
- When exports run again stuff might have changed so I want to
repopulate the variable.
Perhaps I had loaded some magic in Emacs when I tested it that wasn't
preserved in the patch. I'll test it again ASAP.
> - The function `org-koma-letter--get-tagged-content' does not use the
> `info' argument. Also, the function is not documented.
No it doesn't use info. I guess it's just for consistency. It's more
or less taken from ox-groff. I don't mind removing it.
> - The second argument of `org-koma-letter-headline' is misspelled
> (`conents').
Thanks!
> - I would remove the formatting from org-koma-letter-ps-prefix and put
> it in the docstring, simply because the separators for \encl and \cc
> are also not formatted in the KOMA-Script defaults.
So you'd set org-koma-letter-ps-prefix to nil or ""? The thing is, in
scrlttr2 does not add a ps-prefix by itself, which seems inconsistent.
So with your suggesting we'd get a more vanilla feel, which I guess
would normally be nice, but here somehow feel inconsistent to me. I'm
happy to oblige on this issue.
>> One thing I'd like to discuss is whether to adopt headings for TO and
>> FROM also. The Groff exporter already does so for it's letters. The
>> main benefit is that it allows for org-syntax. IMO it's a lot nicer
>> to look at as well. Check the org-groff site in the footnote for an
>> example.
>
> I am not sure about this. I often write a letter below a task in my
> Org files so I rely on exporting the subtree only. So I would have to
> put the TO address below the letter text which looks weird, but is
> doable. On the other hand, being able to use Org syntax and not have to
> escape linebreaks with `\\' is a big plus.
> Maybe both options could be supported. I.e., use a FROM headline if
> available, but fall back on option lines if not? Or is this too
> confusing for users?
The reason why I didn't add it as this point is that I'd want to keep
it 'backward compatible' and I had to think about it. I was toying
with introducing a =:with-legacy= variable that would govern which of
=* TO :TO:= and =#+TO_ADDRESS= would be printed if both are present.
What do you think?
Thanks for your comments.
–Rasmus
--
The Kids call him Billy the Saint
next prev parent reply other threads:[~2013-05-21 17:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 0:28 [patch] ox-koma-letter.el: credit [1/4] Rasmus
2013-05-20 0:40 ` [patch] ox-koma-letter.el: subject changes [2/4] Rasmus
2013-05-20 15:49 ` Alan Schmitt
2013-05-20 18:23 ` Rasmus
2013-05-21 7:24 ` Alan Schmitt
2013-05-21 15:52 ` Viktor Rosenfeld
2013-05-21 17:48 ` Rasmus
2013-05-20 0:51 ` [patch] ox-koma-letter.el: credit [3/4] Rasmus
2013-05-20 15:52 ` Alan Schmitt
2013-05-21 16:56 ` Viktor Rosenfeld
2013-05-21 17:35 ` Rasmus [this message]
2013-05-21 20:06 ` Viktor Rosenfeld
[not found] ` <87zjvo7xkl.fsf@pank.eu>
[not found] ` <20130522145312.GB61443@kenny.local>
2013-05-22 17:16 ` Rasmus
2013-05-22 17:38 ` Viktor Rosenfeld
2013-05-20 0:54 ` [patch] ox-koma-letter.el: clean-up/semantic bug [4/4] Rasmus
[not found] ` <m2ehd1tziq.fsf@polytechnique.org>
2013-05-21 9:05 ` Rasmus
2013-05-21 11:32 ` Alan Schmitt
2013-05-21 12:22 ` Rasmus
2013-05-21 17:02 ` Viktor Rosenfeld
2013-05-21 18:13 ` Rasmus
2013-05-21 19:54 ` Viktor Rosenfeld
2013-05-21 23:23 ` Rasmus
2013-05-22 14:39 ` Viktor Rosenfeld
2013-05-22 22:06 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-25 5:13 ` Robert Klein
2013-05-25 8:05 ` Viktor Rosenfeld
2013-05-25 9:20 ` Alan Schmitt
2013-05-25 13:57 ` Rasmus
2013-05-25 17:03 ` Viktor Rosenfeld
2013-05-25 17:48 ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Rasmus
2013-05-25 21:27 ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-26 10:58 ` Viktor Rosenfeld
2013-05-26 14:38 ` Rasmus
2013-05-26 10:54 ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Viktor Rosenfeld
2013-05-26 14:36 ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-27 6:25 ` Alan Schmitt
2013-05-27 9:22 ` Xavier Garrido
2013-05-27 9:51 ` Rasmus
2013-05-27 18:31 ` Viktor Rosenfeld
2013-05-27 20:42 ` Xavier Garrido
2013-05-26 14:51 ` Rasmus
2013-05-25 20:51 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Robert Klein
2013-05-25 21:41 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults Rasmus
2013-05-26 11:04 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-20 15:44 ` [patch] ox-koma-letter.el: credit [1/4] Alan Schmitt
2013-05-20 15:49 ` Rasmus
2013-05-20 16:01 ` Alan Schmitt
2013-05-21 17:06 ` Viktor Rosenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjvo9qwy.fsf@pank.eu \
--to=rasmus@gmx.us \
--cc=alan.schmitt@polytechnique.org \
--cc=emacs-orgmode@gnu.org \
--cc=listuser36@gmail.com \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).