From: Rasmus <rasmus@gmx.us>
To: alan.schmitt@polytechnique.org
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] ox-koma-letter.el: subject changes [2/4]
Date: Tue, 21 May 2013 19:48:17 +0200 [thread overview]
Message-ID: <87ppwk9qce.fsf@pank.eu> (raw)
In-Reply-To: <20130521155240.GA55239@client199-78.wlan.hu-berlin.de> (Viktor Rosenfeld's message of "Tue, 21 May 2013 17:52:40 +0200")
Viktor Rosenfeld <listuser36@gmail.com> writes:
>> > I found a "bug" in that the subject variable should be a list
>> > cf. the
>> > KOMA manual. This patch fixes this.
>> >
>> > It's pretty complex for something so simple, and I might be
>> > inclined
>> > to admit to the "put it in a LCO"-file approach might be better.
>>
>> I'd really like to have a second opinion on this. Viktor?
>
> I think this patch is great simply from the usability standpoint of
> being able to configure the behavior through customize (which I don't
> generally use, but admit that it's a good thing).
>
> I found a few issues though:
>
> 1. Choosing `No export' in customize results
> `\KOMAoption{subject}{nil}'.
Thanks, that's a bug. I'll look into it ASAP.
> 2. It is not possible to set a subject format in the LCO file because
> if
> `org-koma-letter-subject-format' is set, the KOMA option will be
> overwritten explicitly, and if it is set to `nil' then the subject is
> inhibited altogether. This is actually a problem with the old code as
> well. One way out of this is to only print the subject line (i.e.,
> `\setkomavar{subject}{.}' if `org-koma-letter-subject-format' is nil
> and
> and fix `noexport' to hide the subject (i.e., inhibit
> `\setkomavar{subject}{.}').
Perhaps the ox-latex.el way is the way to go:
#+TITLE: # i.e. nothing
The difference would be that here would have not to format subject
komavar at all.
> Is this the entended behaviour? I'll try to post a patch for this
> later tonight.
Yeah, let's think about it. From my point of view, basically never
using LCO files, I think
1. it should be possible to not post a subject. I tried to implement
this via #+OPTIONS: subject:nil.
2. But perhaps I'm trying to be too clever. I might have defined
komavar-subject in an LCO file, but still changing subject
formating on the go. This is not possible.
3. If letting subject be disabled by an empty title 2. won't break
it. So how about the condition (pseudo lisp):
(or (title is nil) (subject is nil))?
It should be pretty simple to get to that state I think.
> 3. I'm not a big fan of the parentheses in the subject:(.) syntax, but
> if that's required to use an option list with multiple values I think
> it's okay.
OK, perhaps there's a clever way to get it to accept several keywords
without a parenthese. I'm not sure.
> It would be nice to be able to specify a single value without the
> parens, but it's not a high priority (and I don't know how to do
> that).
That should be possible. I thought I'd tested it. Note though, that
giving a single value overwrites the default. I'm not sure whether it
should extend upon the default.
Cheers,
Rasmus
--
C is for Cookie
next prev parent reply other threads:[~2013-05-21 17:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 0:28 [patch] ox-koma-letter.el: credit [1/4] Rasmus
2013-05-20 0:40 ` [patch] ox-koma-letter.el: subject changes [2/4] Rasmus
2013-05-20 15:49 ` Alan Schmitt
2013-05-20 18:23 ` Rasmus
2013-05-21 7:24 ` Alan Schmitt
2013-05-21 15:52 ` Viktor Rosenfeld
2013-05-21 17:48 ` Rasmus [this message]
2013-05-20 0:51 ` [patch] ox-koma-letter.el: credit [3/4] Rasmus
2013-05-20 15:52 ` Alan Schmitt
2013-05-21 16:56 ` Viktor Rosenfeld
2013-05-21 17:35 ` Rasmus
2013-05-21 20:06 ` Viktor Rosenfeld
[not found] ` <87zjvo7xkl.fsf@pank.eu>
[not found] ` <20130522145312.GB61443@kenny.local>
2013-05-22 17:16 ` Rasmus
2013-05-22 17:38 ` Viktor Rosenfeld
2013-05-20 0:54 ` [patch] ox-koma-letter.el: clean-up/semantic bug [4/4] Rasmus
[not found] ` <m2ehd1tziq.fsf@polytechnique.org>
2013-05-21 9:05 ` Rasmus
2013-05-21 11:32 ` Alan Schmitt
2013-05-21 12:22 ` Rasmus
2013-05-21 17:02 ` Viktor Rosenfeld
2013-05-21 18:13 ` Rasmus
2013-05-21 19:54 ` Viktor Rosenfeld
2013-05-21 23:23 ` Rasmus
2013-05-22 14:39 ` Viktor Rosenfeld
2013-05-22 22:06 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-25 5:13 ` Robert Klein
2013-05-25 8:05 ` Viktor Rosenfeld
2013-05-25 9:20 ` Alan Schmitt
2013-05-25 13:57 ` Rasmus
2013-05-25 17:03 ` Viktor Rosenfeld
2013-05-25 17:48 ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Rasmus
2013-05-25 21:27 ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-26 10:58 ` Viktor Rosenfeld
2013-05-26 14:38 ` Rasmus
2013-05-26 10:54 ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Viktor Rosenfeld
2013-05-26 14:36 ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-27 6:25 ` Alan Schmitt
2013-05-27 9:22 ` Xavier Garrido
2013-05-27 9:51 ` Rasmus
2013-05-27 18:31 ` Viktor Rosenfeld
2013-05-27 20:42 ` Xavier Garrido
2013-05-26 14:51 ` Rasmus
2013-05-25 20:51 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Robert Klein
2013-05-25 21:41 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults Rasmus
2013-05-26 11:04 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-20 15:44 ` [patch] ox-koma-letter.el: credit [1/4] Alan Schmitt
2013-05-20 15:49 ` Rasmus
2013-05-20 16:01 ` Alan Schmitt
2013-05-21 17:06 ` Viktor Rosenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppwk9qce.fsf@pank.eu \
--to=rasmus@gmx.us \
--cc=alan.schmitt@polytechnique.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).