* [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols`
@ 2014-09-04 12:43 Jonathan Leech-Pepin
2014-09-04 14:31 ` Jorge A. Alfaro-Murillo
2014-10-12 12:35 ` Bastien
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Leech-Pepin @ 2014-09-04 12:43 UTC (permalink / raw)
To: Org Mode Mailing List; +Cc: jorge.alfaro-murillo
[-- Attachment #1.1: Type: text/plain, Size: 1335 bytes --]
Patch attached and inlined (to ensure gmail does not mangle)
Regards,
Jonathan
org-passwords.el: Fix `org-passwords-generate-password-with-symbols` to not
insert password
* org-passwords.el (org-passwords-generate-password-with-symbols): Do not
insert password,
this matches how `org-passwords-generate-password-without-symbols` behaves.
---
contrib/lisp/org-passwords.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-passwords.el b/contrib/lisp/org-passwords.el
index 7ed8c80..9c3a916 100644
--- a/contrib/lisp/org-passwords.el
+++ b/contrib/lisp/org-passwords.el
@@ -221,12 +221,12 @@ uppercase letters. Argument ARG include symbols."
"Return a string consisting of PREVIOUS-STRING and
NUMS-OF-CHARS random characters."
(if (eq nums-of-chars 0) previous-string
- (insert (org-passwords-generate-password-with-symbols
+ (org-passwords-generate-password-with-symbols
(concat previous-string
(char-to-string
;; symbols, letters, numbers are from 33 to 126
(+ (random (- 127 33)) 33)))
- (1- nums-of-chars)))))
+ (1- nums-of-chars))))
(defun org-passwords-generate-password-without-symbols (previous-string
nums-of-chars)
"Return string consisting of PREVIOUS-STRING and NUMS-OF-CHARS
--
1.7.9
[-- Attachment #1.2: Type: text/html, Size: 1630 bytes --]
[-- Attachment #2: 0001-org-passwords.el-Fix-org-passwords-generate-password.patch --]
[-- Type: application/octet-stream, Size: 1413 bytes --]
From dd99890ac997f61142e4c22bafff4d45ae26bde1 Mon Sep 17 00:00:00 2001
From: Jonathan Leech-Pepin <jonathan.leechpepin@gmail.com>
Date: Thu, 4 Sep 2014 08:31:09 -0400
Subject: [PATCH] org-passwords.el: Fix
`org-passwords-generate-password-with-symbols` to not
insert password
* org-passwords.el (org-passwords-generate-password-with-symbols): Do not insert password,
this matches how `org-passwords-generate-password-without-symbols` behaves.
---
contrib/lisp/org-passwords.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-passwords.el b/contrib/lisp/org-passwords.el
index 7ed8c80..9c3a916 100644
--- a/contrib/lisp/org-passwords.el
+++ b/contrib/lisp/org-passwords.el
@@ -221,12 +221,12 @@ uppercase letters. Argument ARG include symbols."
"Return a string consisting of PREVIOUS-STRING and
NUMS-OF-CHARS random characters."
(if (eq nums-of-chars 0) previous-string
- (insert (org-passwords-generate-password-with-symbols
+ (org-passwords-generate-password-with-symbols
(concat previous-string
(char-to-string
;; symbols, letters, numbers are from 33 to 126
(+ (random (- 127 33)) 33)))
- (1- nums-of-chars)))))
+ (1- nums-of-chars))))
(defun org-passwords-generate-password-without-symbols (previous-string nums-of-chars)
"Return string consisting of PREVIOUS-STRING and NUMS-OF-CHARS
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols`
2014-09-04 12:43 [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols` Jonathan Leech-Pepin
@ 2014-09-04 14:31 ` Jorge A. Alfaro-Murillo
2014-10-12 12:35 ` Bastien
1 sibling, 0 replies; 3+ messages in thread
From: Jorge A. Alfaro-Murillo @ 2014-09-04 14:31 UTC (permalink / raw)
To: emacs-orgmode
Jonathan Leech-Pepin writes:
> Patch attached and inlined (to ensure gmail does not mangle)
> * org-passwords.el
> (org-passwords-generate-password-with-symbols): Do not insert
> password, this matches how
> `org-passwords-generate-password-without-symbols` behaves.
Thanks, I had forgotten to remove that from -with-symbols.
Best,
--
Jorge.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols`
2014-09-04 12:43 [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols` Jonathan Leech-Pepin
2014-09-04 14:31 ` Jorge A. Alfaro-Murillo
@ 2014-10-12 12:35 ` Bastien
1 sibling, 0 replies; 3+ messages in thread
From: Bastien @ 2014-10-12 12:35 UTC (permalink / raw)
To: Jonathan Leech-Pepin; +Cc: jorge.alfaro-murillo, Org Mode Mailing List
Hi Jonathan,
Jonathan Leech-Pepin <jonathan.leechpepin@gmail.com> writes:
> Patch attached and inlined (to ensure gmail does not mangle)
Applied, thanks!
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-12 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-04 12:43 [PATCH] org-passwords.el: Do not insert `org-passwords-generate-password-with-symbols` Jonathan Leech-Pepin
2014-09-04 14:31 ` Jorge A. Alfaro-Murillo
2014-10-12 12:35 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).