From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Marco Wahl <marcowahlsoft@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-babel-goto-named-src-block bugfix and test
Date: Tue, 14 Jun 2016 13:46:03 +0200 [thread overview]
Message-ID: <87ziqo0z9g.fsf@saiph.selenimh> (raw)
In-Reply-To: <84y468vyyk.fsf@gmail.com> (Marco Wahl's message of "Tue, 14 Jun 2016 12:36:51 +0200")
Hello,
Marco Wahl <marcowahlsoft@gmail.com> writes:
> I have no idea for a cleaner implementation of these tests. AFAICS
> these tests look good (and also your code.) If someone has a better
> idea for the tests they can be changed.
I don't.
> I would drop test
>
> #v+
> ;; non-existent name
> (should-not
> (execute-kbd-macro
> "\M-xorg-babel-goto-named-src-block\ndef\n"))
> #v-
>
> because its outcome has nothing to do with the existence of the name
> "def" AFAICS. Or maybe replace with
>
> (should (string= "source-code block `non-existent' not found in this buffer"
> (org-babel-goto-named-src-block "non-existent")))
>
> +1 for commit!
I'm not very keen on having `should' macro in the inner parts of tests,
because it makes debugging failing tests harder, but a test is better
than nothing. So, all in all, it looks good enough to be pushed.
Thank you !
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2016-06-14 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 23:04 [PATCH] org-babel-goto-named-src-block bugfix and test Charles C. Berry
2016-06-12 10:21 ` Marco Wahl
2016-06-12 16:05 ` Charles C. Berry
2016-06-14 10:36 ` Marco Wahl
2016-06-14 11:46 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziqo0z9g.fsf@saiph.selenimh \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=marcowahlsoft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).