emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-babel-goto-named-src-block bugfix and test
Date: Tue, 14 Jun 2016 12:36:51 +0200	[thread overview]
Message-ID: <84y468vyyk.fsf@gmail.com> (raw)
In-Reply-To: alpine.OSX.2.20.1606120833350.556@charles-berrys-macbook.local

>>> The test uses lines like:
>>>
>>> 	(execute-kbd-macro  "\M-xorg-babel-goto-named-src-block\n\n")
>>>
>>> to emulate interactive usage.
>>>
>>> This feels like a hack, and the messages generated spill into my
>>> *shell* buffer when I run `make test'.  If there is a cleaner way to
>>> do this, I'd like to know it.
>>>
>>> WDYT?
>>
>> Why not just use e.g.
>>
>>  (org-babel-goto-named-src-block "def")
>>
>
> Because that does not test the `(interactive ...)' form, which
> comprises most of the code in `org-babel-goto-named-src-block'.

Okay.

I have no idea for a cleaner implementation of these tests.  AFAICS
these tests look good (and also your code.)  If someone has a better
idea for the tests they can be changed.

I would drop test

#v+
;; non-existent name
(should-not
  (execute-kbd-macro
"\M-xorg-babel-goto-named-src-block\ndef\n"))
#v-

because its outcome has nothing to do with the existence of the name
"def" AFAICS.  Or maybe replace with

(should (string= "source-code block `non-existent' not found in this buffer"
(org-babel-goto-named-src-block "non-existent")))

+1 for commit!


Best regards,
-- 
Marco Wahl -- GPG: 0x49010A040A3AE6F2

next prev parent reply	other threads:[~2016-06-14 10:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11 23:04 [PATCH] org-babel-goto-named-src-block bugfix and test Charles C. Berry
2016-06-12 10:21 ` Marco Wahl
2016-06-12 16:05   ` Charles C. Berry
2016-06-14 10:36     ` Marco Wahl [this message]
2016-06-14 11:46       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84y468vyyk.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).