emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: custom port for postgresql
Date: Wed, 14 Sep 2016 00:04:53 -0500	[thread overview]
Message-ID: <87zinb6phm.fsf@alphapapa.net> (raw)
In-Reply-To: CALAc-BuHZW1CJ2Rf3=np=O1=xO0K5d6nuUg-zk54jNmDTB0cnA@mail.gmail.com

Jakob Lombacher <Jakob@lombacher.net> writes:

> -(defun org-babel-sql-dbstring-postgresql (host user database)
> +(defun org-babel-sql-dbstring-postgresql (host port user database)

Hi Jakob,

Two suggestions:

1.  Generally people put something like "[PATCH]" in the subject so that
the maintainers will know it contains a patch.  :)

2.  I'd suggest putting the new `port` argument at the end of the
argument list, after an `&optional`.  Even though it makes more sense to
put it after the host, putting it at the end and making it optional
means that people won't have to change existing code that calls this
function.

Thanks for submitting the patch.

     prev parent reply	other threads:[~2016-09-14  5:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 18:53 custom port for postgresql Jakob Lombacher
2016-09-14  5:04 ` Adam Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zinb6phm.fsf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).