From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adam Porter <adam@alphapapa.net>
Subject: Re: custom port for postgresql
Date: Wed, 14 Sep 2016 00:04:53 -0500
Message-ID: <87zinb6phm.fsf@alphapapa.net>
References: <CALAc-BuHZW1CJ2Rf3=np=O1=xO0K5d6nuUg-zk54jNmDTB0cnA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bk2Nr-0004hQ-5a
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 01:05:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bk2Nm-0003et-U1
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 01:05:18 -0400
Received: from [195.159.176.226] (port=33817 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bk2Nm-0003da-NE
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 01:05:14 -0400
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1bk2Nc-0002vx-3Z
	for emacs-orgmode@gnu.org; Wed, 14 Sep 2016 07:05:04 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Jakob Lombacher <Jakob@lombacher.net> writes:

> -(defun org-babel-sql-dbstring-postgresql (host user database)
> +(defun org-babel-sql-dbstring-postgresql (host port user database)

Hi Jakob,

Two suggestions:

1.  Generally people put something like "[PATCH]" in the subject so that
the maintainers will know it contains a patch.  :)

2.  I'd suggest putting the new `port` argument at the end of the
argument list, after an `&optional`.  Even though it makes more sense to
put it after the host, putting it at the end and making it optional
means that people won't have to change existing code that calls this
function.

Thanks for submitting the patch.