emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Use lexical-binding cookie in some trivial files
@ 2021-01-24  1:20 Stefan Kangas
  2021-01-25  3:40 ` Kyle Meyer
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2021-01-24  1:20 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

I'm trying to reduce the number of files in the Emacs source tree where
lexical-binding is nil.  It would be nice if we could fix org-version.el
and org-install.el, like in the attached patch.

Thanks in advance.

[-- Attachment #2: 0001-Use-lexical-binding-cookie-in-some-trivial-files.patch --]
[-- Type: text/x-diff, Size: 1279 bytes --]

From c1d8378074bde48528943b36b38cbb5b3c058b21 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Sun, 24 Jan 2021 02:05:02 +0100
Subject: [PATCH] Use lexical-binding cookie in some trivial files

* mk/org-fixup.el (org-make-org-version): Add lexical-binding cookie
to autogenerated files.
* lisp/org-install.el: Use lexical-binding.
---
 lisp/org-install.el | 2 +-
 mk/org-fixup.el     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-install.el b/lisp/org-install.el
index 583595973..d521d819d 100644
--- a/lisp/org-install.el
+++ b/lisp/org-install.el
@@ -1,4 +1,4 @@
-;;; org-install.el --- backward compatibility file for obsolete configuration
+;;; org-install.el --- backward compatibility file for obsolete configuration  -*- lexical-binding: t -*-
 ;;
 ;;; Code:
 ;;
diff --git a/mk/org-fixup.el b/mk/org-fixup.el
index bc7c6e528..c0eef23cb 100644
--- a/mk/org-fixup.el
+++ b/mk/org-fixup.el
@@ -43,7 +43,7 @@ work correctly if this file is not present (except directly from
 the Git work tree)."
   (with-temp-buffer
     (insert "\
-;;; org-version.el --- autogenerated file, do not edit
+;;; org-version.el --- autogenerated file, do not edit  -*- lexical-binding: t -*-
 ;;
 ;;; Code:
 ;;;\#\#\#autoload
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use lexical-binding cookie in some trivial files
  2021-01-24  1:20 [PATCH] Use lexical-binding cookie in some trivial files Stefan Kangas
@ 2021-01-25  3:40 ` Kyle Meyer
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2021-01-25  3:40 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Org-mode

Stefan Kangas writes:

> I'm trying to reduce the number of files in the Emacs source tree where
> lexical-binding is nil.  It would be nice if we could fix org-version.el
> and org-install.el, like in the attached patch.

Applied (a50a42cea).  Thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-25  3:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-24  1:20 [PATCH] Use lexical-binding cookie in some trivial files Stefan Kangas
2021-01-25  3:40 ` Kyle Meyer

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).