emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: Juan <pechiar@computer.org>
Cc: emacs-orgmode@gnu.org, Ivanov Dmitry <usr345@gmail.com>
Subject: Re: need detailed instructions for submitting the patch
Date: Mon, 09 Aug 2010 20:55:57 -0400	[thread overview]
Message-ID: <87y6cfb80y.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <20100809233613.GA2414@soloJazz.com> (Juan's message of "Mon, 9 Aug 2010 20:36:13 -0300")

Juan <pechiar@computer.org> writes:

> On Tue, Aug 10, 2010 at 01:59:57AM +0400, Ivanov Dmitry wrote:
>> The http://orgmode.org/worg/org-contribute.php#sec-3 says:
>> "Git can be used to make patches and send them via email - this is
>> perfectly fine for minor changes. These patches will be
>> automatically registered at John Wiegley's patchwork server"
>>
>> Please, tell me, what commands should I run to create a patch,
>> upload it and get any feedback from the senior developers?
>
> The following command will make a patch between the staging area
> (in your computer), and the file you modified:
>
>     git diff -p org-whatever.el
>
> If you already committed your changes to your index (staging area),
> then you should compare against a particular branch (in this example,
> origin/master):
>
>     git diff -p origin/master org-whatever.el
>
> You email the output to this mailing list, adding [PATCH] to the
> subject, and description of what you fixed or changed.
>
> At least, this is how I do it.
>
> Regards,
> .j.

It's easier to make real commits on a topic branch and use either git
send-email or git format-patch to create the properly formatted patch
files.

I personally use git send-email --annotate -N (where N is the number of
commits I want to create patches for.  For example,
git send-email --annotate -1 if it is a single commit)

I have the following in my .git/config so that git send-email knows
where to send the resulting patches

,----[ .git/config ]
| [sendemail]
| 	to = emacs-orgmode@gnu.org
`----

Alternatively, git format-patch will create sequentially numbered files
which you can edit and mail manually from your email client.

HTH,
Bernt

  reply	other threads:[~2010-08-10  0:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 21:59 Ivanov Dmitry
2010-08-09 23:36 ` Juan
2010-08-10  0:55   ` Bernt Hansen [this message]
2010-08-10 15:00     ` Re[2]: " Ivanov Dmitry
2010-08-10 15:30       ` Bastien
2010-08-10 17:33         ` Re[2]: " Ivanov Dmitry
2010-08-10 17:47           ` Bastien
2010-08-10 17:57             ` Nick Dokos
2010-08-10 18:11               ` Dan Davison
2010-08-10 20:39                 ` David Maus
2010-08-10 18:14               ` Re[2]: Re[2]: " Ivanov Dmitry
2010-08-10 18:29                 ` Nick Dokos
2010-08-10 18:29                 ` Thomas S. Dye
2010-08-11  5:09                   ` ReRe[2]: " Noorul Islam K M
2010-08-11 22:16                 ` Re[2]: " Bastien
2010-08-11 23:00               ` Bastien
2010-08-10 15:34       ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6cfb80y.fsf@gollum.intra.norang.ca \
    --to=bernt@norang.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=pechiar@computer.org \
    --cc=usr345@gmail.com \
    --subject='Re: need detailed instructions for submitting the patch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).