Re: need detailed instructions for submitting the patch

From: Dan Davison <davison@stats.ox.ac.uk>
To: nicholas.dokos@hp.com
Cc: Ivanov Dmitry <usr345@gmail.com>,
	emacs-orgmode@gnu.org, Bastien <bastien.guerry@wikimedia.fr>
Subject: Re: need detailed instructions for submitting the patch
Date: Tue, 10 Aug 2010 14:11:18 -0400	[thread overview]
Message-ID: <87sk2mwd6h.fsf@stats.ox.ac.uk> (raw)
In-Reply-To: <19674.1281463074@gamaville.dokosmarshall.org> (Nick Dokos's message of "Tue, 10 Aug 2010 13:57:54 -0400")

Nick Dokos <nicholas.dokos@hp.com> writes:

> Bastien <bastien.guerry@wikimedia.fr> wrote:
>
>
>> > For example, I have a modified file org-whatever.el. What commands
>> > must I run?
>> 
>> Please follow the instructions on Worg and let us know what is not
>> crystal-clear -- that will help improve the doc if necessary.
>> 
>
> I think Dmitry is asking for the git commands and I'm not sure those
> are described anywhere on Worg.
>
> Something like this perhaps:
>
>          # create a topic branch to deal with a specific topic: use
>          # a descriptive name!
>          git checkout -b topic-branch-foo master
>          <make changes specific to topic>
>          git commit -a
>          git format-patch
>          <send out patch in email to appropriate mailing list>

One point I'm not yet clear on:

For the patchwork system, what methods of inclusion of patch in email
are acceptable?

+ attachment type text/plain?
+ attachment type text/x-diff?
+ attach using C-c C-a in gnus but choose "inline" rather than as
  "attachment"?
+ paste inline?
+ paste inline with special gnus separators --8<-- ?

does it matter how the patch file is named?

Also, what requirements are there on how to *reply* so that your message
gets lumped by patchwork into the same patch item, rather than creating
a new item? Can the subject line be modified?

Dan

>          
> Then when the patch hits mainline (or it is irrevocably rejected), get
> rid of the branch:
>
>          git branch -D topic-branch
>
> Nick
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode