emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)]
Date: Thu, 10 Jan 2013 09:55:56 +0100	[thread overview]
Message-ID: <87y5g176xv.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: 8738y98me6.fsf@thinkpad.tsdh.de

Tassilo Horn <tsdh@gnu.org> writes:

>> I've done the bisecting:
>> 7684fbd6a227f0ad182661fd7eb17a9e13dc4695 is the first bad commit
>> commit 7684fbd6a227f0ad182661fd7eb17a9e13dc4695
>> Author: Nicolas Goaziou <n.goaziou@gmail.com>
>> Date:   Tue Jan 8 10:34:40 2013 +0100
>>     Ignore `auto-fill-inhibit-regexp'
> Sorry for the noise, but I must have done something wrong during
> bisect.  The previous commit is also "bad", so Nicolas isn't the one
> to blame here.  I'll bisect again...

Ok, here's the new bisecting result, and that seems reasonable:

c8bfd50223d1a75d12d7f74571c24951592c56ec is the first bad commit
commit c8bfd50223d1a75d12d7f74571c24951592c56ec
Author: Bastien Guerry <bzg@altern.org>
Date:   Mon Jan 7 16:12:52 2013 +0100

    org-agenda.el: New option `org-agenda-use-tag-inheritance'
    * org-agenda.el (org-search-view, org-agenda-get-todos)
    (org-agenda-get-timestamps, org-agenda-get-sexps)
    (org-agenda-get-progress, org-agenda-get-deadlines)
    (org-agenda-get-scheduled, org-agenda-get-blocks)
    (org-agenda-change-all-lines): Get local tags only.
    (org-agenda-use-tag-inheritance): New option.
    (org-agenda-finalize): When `org-agenda-use-tag-inheritance'
    is non-nil, possibly reset tags in the agenda buffer.
    (org-agenda-check-type): Enhance docstring.
    See the docstring of the new option for details.

:040000 040000 78b4635191f9aadf4fb1e4aaf4fce5c503e24ef6
cfc6f54ff9328ec0f338f2050b913ae7dfbb399b M	lisp

In the diff of that commit, I see a lot of changes like

-                 (setq tags (org-get-tags-at))
+                 (setq tags (org-get-tags-at nil t))

i.e., it used to show all tags (local and inherited), and now it's
explicitly said to display only local tags.

I've validated the result: with c8bfd50223d1a75d12d7f74571c24951592c56ec
tag inheritance is broken, with its predecessor babba02 it does work


  reply	other threads:[~2013-01-10  8:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10  7:43 Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)] Tassilo Horn
2013-01-10  8:33 ` Tassilo Horn
2013-01-10  8:36   ` Tassilo Horn
2013-01-10  8:55     ` Tassilo Horn [this message]
2013-01-10 10:45 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5g176xv.fsf@thinkpad.tsdh.de \
    --to=tsdh@gnu.org \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).