From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tassilo Horn Subject: Re: Bug: Tag inheritance broken in agenda/timeline buffers [7.9.3a (release_7.9.3a-803-gf8f548 @ /home/horn/Repos/el/org-mode/lisp/)] Date: Thu, 10 Jan 2013 09:55:56 +0100 Message-ID: <87y5g176xv.fsf@thinkpad.tsdh.de> References: <87bocx8oud.fsf@thinkpad.tsdh.de> <877gnl8mk4.fsf@thinkpad.tsdh.de> <8738y98me6.fsf@thinkpad.tsdh.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtDvw-0001bz-7Z for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 03:56:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtDvu-0001mr-Ql for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 03:56:20 -0500 Received: from plane.gmane.org ([80.91.229.3]:46108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtDvu-0001mk-Jt for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 03:56:18 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TtDw7-0004LH-73 for emacs-orgmode@gnu.org; Thu, 10 Jan 2013 09:56:31 +0100 Received: from tsdh.uni-koblenz.de ([141.26.67.142]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 10 Jan 2013 09:56:31 +0100 Received: from tsdh by tsdh.uni-koblenz.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 10 Jan 2013 09:56:31 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Tassilo Horn writes: >> I've done the bisecting: >> >> 7684fbd6a227f0ad182661fd7eb17a9e13dc4695 is the first bad commit >> commit 7684fbd6a227f0ad182661fd7eb17a9e13dc4695 >> Author: Nicolas Goaziou >> Date: Tue Jan 8 10:34:40 2013 +0100 >> >> Ignore `auto-fill-inhibit-regexp' > > Sorry for the noise, but I must have done something wrong during > bisect. The previous commit is also "bad", so Nicolas isn't the one > to blame here. I'll bisect again... Ok, here's the new bisecting result, and that seems reasonable: c8bfd50223d1a75d12d7f74571c24951592c56ec is the first bad commit commit c8bfd50223d1a75d12d7f74571c24951592c56ec Author: Bastien Guerry Date: Mon Jan 7 16:12:52 2013 +0100 org-agenda.el: New option `org-agenda-use-tag-inheritance' * org-agenda.el (org-search-view, org-agenda-get-todos) (org-agenda-get-timestamps, org-agenda-get-sexps) (org-agenda-get-progress, org-agenda-get-deadlines) (org-agenda-get-scheduled, org-agenda-get-blocks) (org-agenda-change-all-lines): Get local tags only. (org-agenda-use-tag-inheritance): New option. (org-agenda-finalize): When `org-agenda-use-tag-inheritance' is non-nil, possibly reset tags in the agenda buffer. (org-agenda-check-type): Enhance docstring. See the docstring of the new option for details. :040000 040000 78b4635191f9aadf4fb1e4aaf4fce5c503e24ef6 cfc6f54ff9328ec0f338f2050b913ae7dfbb399b M lisp In the diff of that commit, I see a lot of changes like - (setq tags (org-get-tags-at)) + (setq tags (org-get-tags-at nil t)) i.e., it used to show all tags (local and inherited), and now it's explicitly said to display only local tags. I've validated the result: with c8bfd50223d1a75d12d7f74571c24951592c56ec tag inheritance is broken, with its predecessor babba02 it does work again. Bye, Tassilo