* Scheduling makes link disappear
@ 2013-02-01 11:54 Thomas Morgan
2013-02-07 10:42 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Morgan @ 2013-02-01 11:54 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Dear Org mode hackers,
In an Org TODO list, scheduling an item that contains a link can cause
the link to disappear.
Here's how to reproduce this:
Run `emacs -Q -l setup.el'.
Type `M-x org-agenda' , then `t' to show a TODO list.
This splits the frame horizontally into two windows,
each one 84 columns wide on this computer.
Move point to the TODO item, which looks like this:
test-case: TODO Visit test link
Type `C-c C-s RET' to schedule the item for today.
Now the line looks like this:
test-case: TODO Visit
I expected it to look something like this:
test-case: TODO Visit this link S => Scheduled to <2013-01-28 Mon>
And in fact this is how it looks when the window is wider
(172 columns).
I'm ttaching `setup.el' and `test-case.org'.
Thanks,
Thomas
[-- Attachment #2: setup.el --]
[-- Type: application/emacs-lisp, Size: 111 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: test-case.org --]
[-- Type: text/x-org, Size: 108 bytes --]
* TODO Visit [[http://www.this-is-a-long-long-long-long-long-long-long-domain-name.com/][test link]]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Scheduling makes link disappear
2013-02-01 11:54 Scheduling makes link disappear Thomas Morgan
@ 2013-02-07 10:42 ` Bastien
2013-02-10 19:56 ` Thomas Morgan
0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2013-02-07 10:42 UTC (permalink / raw)
To: Thomas Morgan; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
Hi Thomas,
Thomas Morgan <tlm@ziiuu.com> writes:
> In an Org TODO list, scheduling an item that contains a link can cause
> the link to disappear.
Thanks very for the report.
Please try the attached patch and let me know if it fixes it (it
should) but more importantly: if it breaks other agenda views.
Best,
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-agenda-fix-display.patch --]
[-- Type: text/x-patch, Size: 1272 bytes --]
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 9b6dcae..59be594 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -8686,9 +8686,8 @@ Called with a universal prefix arg, show the priority instead of setting it."
(defun org-agenda-show-new-time (marker stamp &optional prefix)
"Show new date stamp via text properties."
;; We use text properties to make this undoable
- (let ((inhibit-read-only t)
- (buffer-invisibility-spec))
- (setq stamp (concat " " prefix " => " stamp))
+ (let ((inhibit-read-only t))
+ (setq stamp (concat prefix " => " stamp " "))
(save-excursion
(goto-char (point-max))
(while (not (bobp))
@@ -8750,7 +8749,7 @@ ARG is passed through to `org-schedule'."
(widen)
(goto-char pos)
(setq ts (org-schedule arg time)))
- (org-agenda-show-new-time marker ts "S"))
+ (org-agenda-show-new-time marker ts " S"))
(message "%s" ts)))
(defun org-agenda-deadline (arg &optional time)
@@ -8770,7 +8769,7 @@ ARG is passed through to `org-deadline'."
(widen)
(goto-char pos)
(setq ts (org-deadline arg time)))
- (org-agenda-show-new-time marker ts "D"))
+ (org-agenda-show-new-time marker ts " D"))
(message "%s" ts)))
(defun org-agenda-clock-in (&optional arg)
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: Scheduling makes link disappear
2013-02-07 10:42 ` Bastien
@ 2013-02-10 19:56 ` Thomas Morgan
2013-02-11 13:57 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Morgan @ 2013-02-10 19:56 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
Hi, Bastien,
Thanks! That fixes it and doesn't break any of the agenda views
that I use.
Best regards,
Thomas
Bastien <bzg@altern.org> writes:
> Hi Thomas,
>
> Thomas Morgan <tlm@ziiuu.com> writes:
>
>> In an Org TODO list, scheduling an item that contains a link can cause
>> the link to disappear.
>
> Thanks very for the report.
>
> Please try the attached patch and let me know if it fixes it (it
> should) but more importantly: if it breaks other agenda views.
>
> Best,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-11 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-01 11:54 Scheduling makes link disappear Thomas Morgan
2013-02-07 10:42 ` Bastien
2013-02-10 19:56 ` Thomas Morgan
2013-02-11 13:57 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).