emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] make vanilla: run Emacs -Q with this Org loaded
@ 2013-12-13 16:34 schulte.eric
  2013-12-13 22:47 ` Achim Gratz
  0 siblings, 1 reply; 3+ messages in thread
From: schulte.eric @ 2013-12-13 16:34 UTC (permalink / raw)
  To: Org Mode Mailing List

I think this change could make it easier to reproduce problems with
Org-mode loaded and without the user's personal config loaded.

Thoughts?

---
 Makefile      |  1 +
 mk/default.mk | 13 +++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/Makefile b/Makefile
index f95bcb2..ce06116 100644
--- a/Makefile
+++ b/Makefile
@@ -30,6 +30,7 @@ help helpall::
 	$(info make single         - build Org ELisp files, single Emacs per source)
 	$(info make autoloads      - create org-loaddefs.el to load Org in-place)
 	$(info make test           - build Org ELisp files and run test suite)
+	$(info make vanilla        - run Emacs with this Org-mode and no personal config)
 helpall::
 	$(info make test-dirty     - check without building first)
 	$(info make compile-dirty  - build only stale Org ELisp files)
diff --git a/mk/default.mk b/mk/default.mk
index 886efc6..54148be 100644
--- a/mk/default.mk
+++ b/mk/default.mk
@@ -72,6 +72,19 @@ BTEST	= $(BATCH) \
 	  $(foreach req,$(BTEST_EXTRA),$(req-extra)) \
 	  --eval '(org-test-run-batch-tests org-test-select-re)'
 
+# Running a plain emacs with no config and this Org-mode loaded.  This
+# should be useful for testing and for manually verrifying problems.
+MINI = $(EMACS) -Q \
+	  --eval '(add-to-list '"'"'load-path (concat default-directory "lisp"))' \
+	  --eval '(setq org-babel-load-languages \
+	          (quote ($(foreach ob-lang,$(BTEST_OB_LANGUAGES) emacs-lisp sh org,$(lst-ob-lang)))) \
+	  )' \
+	  -l org-loaddefs.el -l cl -l org -l ox -f org-version
+
+.PHONY: minimal
+vanilla:
+	$(MINI) &
+
 # Using emacs in batch mode.
 # BATCH = $(EMACS) -batch -vanilla # XEmacs
 BATCH	= $(EMACS) -batch -Q \
-- 
1.8.5.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] make vanilla: run Emacs -Q with this Org loaded
  2013-12-13 16:34 [PATCH] make vanilla: run Emacs -Q with this Org loaded schulte.eric
@ 2013-12-13 22:47 ` Achim Gratz
  2013-12-13 23:28   ` Eric Schulte
  0 siblings, 1 reply; 3+ messages in thread
From: Achim Gratz @ 2013-12-13 22:47 UTC (permalink / raw)
  To: emacs-orgmode

schulte.eric@gmail.com writes:
> I think this change could make it easier to reproduce problems with
> Org-mode loaded and without the user's personal config loaded.

So you want $(BATCH) with "-batch" filtered out?  You can do that
without the code duplication.

> +	  --eval '(setq org-babel-load-languages \
> +	          (quote ($(foreach ob-lang,$(BTEST_OB_LANGUAGES) emacs-lisp sh org,$(lst-ob-lang)))) \
> +	  )' \
> +	  -l org-loaddefs.el -l cl -l org -l ox -f org-version

These are specifically needed for batch testing.  I wouldn't want to
load all of these for a minimal Emacs.

> +.PHONY: minimal
> +vanilla:

Does not match (minimal<=>vanilla) and targets don't belong in
default.mk.


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] make vanilla: run Emacs -Q with this Org loaded
  2013-12-13 22:47 ` Achim Gratz
@ 2013-12-13 23:28   ` Eric Schulte
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Schulte @ 2013-12-13 23:28 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Achim Gratz <Stromeko@nexgo.de> writes:

> schulte.eric@gmail.com writes:
>> I think this change could make it easier to reproduce problems with
>> Org-mode loaded and without the user's personal config loaded.
>
> So you want $(BATCH) with "-batch" filtered out?  

Essentially.

> You can do that without the code duplication.
>

Ah, I had no idea.  I see now that the filter-out command does just
this.  I'm consistently surprised at the depth of the Makefile tooling.

>
>> +	  --eval '(setq org-babel-load-languages \
>> +	          (quote ($(foreach ob-lang,$(BTEST_OB_LANGUAGES) emacs-lisp sh org,$(lst-ob-lang)))) \
>> +	  )' \
>> +	  -l org-loaddefs.el -l cl -l org -l ox -f org-version
>
> These are specifically needed for batch testing.  I wouldn't want to
> load all of these for a minimal Emacs.
>
>> +.PHONY: minimal
>> +vanilla:
>
> Does not match (minimal<=>vanilla) and targets don't belong in
> default.mk.
>

Okay, this last point was just a bug, I changed the name part way
through.

I've cleaned up this patch per your suggestions and just pushed a better
version up.

Thanks for the feedback,

>
>
> Achim.

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-13 23:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-13 16:34 [PATCH] make vanilla: run Emacs -Q with this Org loaded schulte.eric
2013-12-13 22:47 ` Achim Gratz
2013-12-13 23:28   ` Eric Schulte

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).