From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG, PATCH] org-indent-mode not correctly deactivated
Date: Thu, 16 Jan 2014 01:19:34 +0100 [thread overview]
Message-ID: <87y52gojys.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87txd5vsw9.fsf@gmail.com> (Nicolas Goaziou's message of "Wed, 15 Jan 2014 22:26:14 +0100")
Nicolas Goaziou <n.goaziou@gmail.com> writes:
> (defun org-mode-restart ()
> (interactive)
> (let ((indent-status (org-bound-and-true-p org-indent-mode)))
> (funcall major-mode)
> (hack-local-variables)
> (when (and indent-status (not (org-bound-and-true-p org-indent-mode)))
> (org-indent-mode -1)))
> (message "%s restarted" major-mode))
>
> Still not pretty, but a bit better, IMO.
Definitely better, I applied this.
> Also, there's a dangling (defvar org-indent-mode nil) in org.el that
> looks suspicious. I don't think we need it if we use
> `org-bound-and-true-p' whenever we need to check for `org-indent-mode'
> value.
Indeed, I removed this.
Thanks!
--
Bastien
prev parent reply other threads:[~2014-01-16 0:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 16:00 [BUG, PATCH] org-indent-mode not correctly deactivated Bastien
2014-01-15 12:56 ` Nicolas Goaziou
2014-01-15 16:34 ` Bastien
2014-01-15 16:44 ` Nicolas Goaziou
2014-01-15 16:53 ` Bastien
2014-01-15 16:56 ` Bastien
2014-01-15 21:26 ` Nicolas Goaziou
2014-01-16 0:19 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y52gojys.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).