emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG, PATCH] org-indent-mode not correctly deactivated
Date: Wed, 15 Jan 2014 13:56:46 +0100	[thread overview]
Message-ID: <877ga1s8s1.fsf@gmail.com> (raw)
In-Reply-To: <87fvoqh7tf.fsf@bzg.ath.cx> (Bastien's message of "Tue, 14 Jan 2014 17:00:44 +0100")

Hello,

Bastien <bzg@gnu.org> writes:

> With a file like
>
> ,----
> | #+STARTUP: indent
> | 
> | * Heading
> | ** Subheading
> `----
>
> org-mode will correctly use org-indent-mode when displaying it.
>
> Now edit the file to deactivate org-indent:
>
> ,----
> | #+STARTUP: noindent
> | 
> | * Heading
> | ** Subheading
> `----
>
> Go to #+STARTUP and hit C-c C-c : org-indent-mode will not be
> activated, but it will not be properly deactivated, leaving a
> confusing whitespace before indented headlines.
>
> The attached patch fixes the problem, but it is wrong, because it
> "actively" deactivates org-indent-mode each time a buffer is not
> using org-indent-mode, in sessions where org-indent-mode has been
> used at least once.

There is no attached patch in your mail. Though, I don't understand why
you think your approach is wrong. In `org-mode' mode definition, we can
change:

  (when org-startup-indented (require 'org-indent) (org-indent-mode 1))

into:

  (cond (org-startup-indented (require 'org-indent) (org-indent-mode 1))
        ((org-bound-and-true-p org-indent-mode) (org-indent-mode -1)))

It's probably similar to what you wrote in your patch.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2014-01-15 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 16:00 Bastien
2014-01-15 12:56 ` Nicolas Goaziou [this message]
2014-01-15 16:34   ` Bastien
2014-01-15 16:44     ` Nicolas Goaziou
2014-01-15 16:53       ` Bastien
2014-01-15 16:56         ` Bastien
2014-01-15 21:26         ` Nicolas Goaziou
2014-01-16  0:19           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ga1s8s1.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [BUG, PATCH] org-indent-mode not correctly deactivated' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).