From: Matt Lundin <mdl@imapmail.org>
To: "Stephen J. Barr" <stevejb@uw.edu>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH] Re: helm-mode-org-set-tags adding additional tags
Date: Wed, 12 Aug 2015 23:31:50 -0500 [thread overview]
Message-ID: <87y4hfu7ux.fsf@fastmail.fm> (raw)
In-Reply-To: CAO1hKsvc80U-z=bN8A4u+SsPQUzFsiFJ5Fw4GPEWtcGiCa_ZfA@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
"Stephen J. Barr" <stevejb@uw.edu> writes:
> I am using org-mode 8.2.10 with helm. When I am adding tags to a
> headline, the first tag offers me completions of all possible tags in
> the file. However, if I go back later and add additional tags, I am
> not offered completion. How can I fix this?
I can confirm that this is not just a helm problem. There is a bug with
all completion backends with the the following *default* settings:
(setq org-use-fast-tag-selection 'auto) ;; provided that shortcuts are
;; defined in org-tag-alist
(setq org-fast-tag-selection-single-key nil)
(setq org-complete-tags-always-offer-all-agenda-tags nil)
Steps to replicate (without helm):
M-x org-set-tags
[Tab] Select via completion [Ret]
[Tab] Only the most recent tab appears [Ret]
The following patch should fix the problem.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-completion-when-selecting-more-than-one-tag.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]
From 370ba61a4647bb97d2233ccb6ef84db033824248 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Wed, 12 Aug 2015 23:22:22 -0500
Subject: [PATCH] Fix completion when selecting more than one tag
* lisp/org.el (org-fast-tag-selection): Make sure to set local variable
buffer-tags to actual buffer-tags before pushing selected tag to the
list; otherwise, the subsequent completion list will be limited to the
one selected tag.
---
lisp/org.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index a908d9e..d7528fc 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15314,7 +15314,8 @@ Returns the new tags string, or nil to not change the current settings."
"Tag: "
(or buffer-tags
(with-current-buffer buf
- (org-get-buffer-tags)))))
+ (setq buffer-tags
+ (org-get-buffer-tags))))))
(quit (setq tg "")))
(when (string-match "\\S-" tg)
(add-to-list 'buffer-tags (list tg))
--
2.5.0
next prev parent reply other threads:[~2015-08-13 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 21:36 helm-mode-org-set-tags adding additional tags Stephen J. Barr
2015-08-13 4:31 ` Matt Lundin [this message]
2015-08-14 0:04 ` [PATCH] " Nicolas Goaziou
2015-08-18 16:17 ` Bastien
2015-08-18 16:17 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4hfu7ux.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
--cc=stevejb@uw.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).