From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: [PATCH] Re: helm-mode-org-set-tags adding additional tags Date: Wed, 12 Aug 2015 23:31:50 -0500 Message-ID: <87y4hfu7ux.fsf@fastmail.fm> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPkBH-0003ht-L2 for emacs-orgmode@gnu.org; Thu, 13 Aug 2015 00:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPkBE-00040T-Ei for emacs-orgmode@gnu.org; Thu, 13 Aug 2015 00:31:55 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPkBE-00040J-5E for emacs-orgmode@gnu.org; Thu, 13 Aug 2015 00:31:52 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Stephen J. Barr" Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain "Stephen J. Barr" writes: > I am using org-mode 8.2.10 with helm. When I am adding tags to a > headline, the first tag offers me completions of all possible tags in > the file. However, if I go back later and add additional tags, I am > not offered completion. How can I fix this? I can confirm that this is not just a helm problem. There is a bug with all completion backends with the the following *default* settings: (setq org-use-fast-tag-selection 'auto) ;; provided that shortcuts are ;; defined in org-tag-alist (setq org-fast-tag-selection-single-key nil) (setq org-complete-tags-always-offer-all-agenda-tags nil) Steps to replicate (without helm): M-x org-set-tags [Tab] Select via completion [Ret] [Tab] Only the most recent tab appears [Ret] The following patch should fix the problem. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-completion-when-selecting-more-than-one-tag.patch >From 370ba61a4647bb97d2233ccb6ef84db033824248 Mon Sep 17 00:00:00 2001 From: Matt Lundin Date: Wed, 12 Aug 2015 23:22:22 -0500 Subject: [PATCH] Fix completion when selecting more than one tag * lisp/org.el (org-fast-tag-selection): Make sure to set local variable buffer-tags to actual buffer-tags before pushing selected tag to the list; otherwise, the subsequent completion list will be limited to the one selected tag. --- lisp/org.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index a908d9e..d7528fc 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -15314,7 +15314,8 @@ Returns the new tags string, or nil to not change the current settings." "Tag: " (or buffer-tags (with-current-buffer buf - (org-get-buffer-tags))))) + (setq buffer-tags + (org-get-buffer-tags)))))) (quit (setq tg ""))) (when (string-match "\\S-" tg) (add-to-list 'buffer-tags (list tg)) -- 2.5.0 --=-=-=--