From: Thorsten Jolitz <tjolitz@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Use of deprecated org-log-note-marker variable in outshine
Date: Thu, 04 Feb 2016 00:02:41 +0100 [thread overview]
Message-ID: <87y4b1gzxq.fsf@gmail.com> (raw)
In-Reply-To: CAFyQvY1gCBnv5axw-ZEcLE84eBzbJNYYVCm41OrKKmY9QEM_pw@mail.gmail.com
Kaushal Modi <kaushal.modi@gmail.com> writes:
Hi Kaushal,
> Recently the global variable org-log-note-marker was removed from
> org.el.
>
> But it is used in outshine.el as follows:
>
> (defadvice org-store-log-note (around org-store-log-note-around
> activate)
> "Outcomment inserted log-note in Outshine buffers."
> (let ((outshine-log-note-beg-marker
> ;; stay before inserted text
> (copy-marker org-log-note-marker nil))
> (outshine-log-note-end-marker
> ;; stay after inserted text
> (copy-marker org-log-note-marker t)))
> ad-do-it
> (unless (derived-mode-p 'org-mode 'org-agenda-mode)
> (comment-region outshine-log-note-beg-marker
> outshine-log-note-end-marker))
> (move-marker outshine-log-note-beg-marker nil)
> (move-marker outshine-log-note-end-marker nil)))
>
> So right now, I am getting this warning at emacs startup:
>
> ~/.emacs.d/elpa_25_0/outshine-20151203.802/outshine.elc:Warning:
> reference to
> free variable ‘org-log-note-marker’
>
> @ Thorsten, Nicolas: What would be the best way to fix that?
>
> My org version:
> Org-mode version 8.3.2 (release_8.3.2-469-ga902c8 @
> /home/kmodi/usr_local/apps/6/emacs/emacs-25/share/emacs/site-lisp/org/)
Thanks for the bug report. Sorry for beeing so late ... but maybe better
late than never.
I pushed a first fix to origin/trunk. The outcommenting of inserted
log-notes in outshine seems to work again, but I encountered a new issue
with comment-region:
,----
| ;; * WAITING foo
| ;; - State "WAITING" from "TODO" [2016-02-03 Mi 23:46] \\
| ;; waiting for bar
`----
It produces this now, which is no good, since outshine expects comments
to start at beginning-of-line. I reported this on Emacs Help.
Which Org-mode version is the first one with the new org-log-note-marker
semantics (to make the advice in outshine conditional on that)?
I push this to master once its really fixed.
--
cheers,
Thorsten
prev parent reply other threads:[~2016-02-03 23:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 23:09 Use of deprecated org-log-note-marker variable in outshine Kaushal Modi
2016-01-07 16:38 ` Thorsten Jolitz
2016-01-07 16:56 ` Kaushal Modi
2016-01-08 13:21 ` Nicolas Goaziou
2016-01-08 15:45 ` Kaushal Modi
2016-01-08 16:28 ` Nicolas Richard
2016-01-31 22:11 ` Nicolas Goaziou
2016-02-03 23:04 ` Thorsten Jolitz
2016-02-03 23:02 ` Thorsten Jolitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4b1gzxq.fsf@gmail.com \
--to=tjolitz@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).