From: Nicolas Richard <nrichard@ulb.ac.be>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>,
Thorsten Jolitz <tjolitz@gmail.com>
Subject: Re: Use of deprecated org-log-note-marker variable in outshine
Date: Fri, 08 Jan 2016 17:28:23 +0100 [thread overview]
Message-ID: <87d1tc3ujc.fsf@ulb.ac.be> (raw)
In-Reply-To: <87vb74p5p6.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 08 Jan 2016 14:21:41 +0100")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Actually, it was a mistake to remove the variable in the first place. As
> a consequence, I re-introduced it in master.
>
> However, it doesn't store the same location as before, i.e., it merely
> points to the entry where the note is going to be added instead of the
> accurate location for the note.
Did you consider renaming it, in the case some code relies on it ?
> (with-current-buffer (marker-buffer org-log-note-marker)
> (goto-char (org-log-note-marker))
^ ^
I guess those parens are a typo.
> (copy-marker (org-log-beginning)))
--
Nicolas
next prev parent reply other threads:[~2016-01-08 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 23:09 Use of deprecated org-log-note-marker variable in outshine Kaushal Modi
2016-01-07 16:38 ` Thorsten Jolitz
2016-01-07 16:56 ` Kaushal Modi
2016-01-08 13:21 ` Nicolas Goaziou
2016-01-08 15:45 ` Kaushal Modi
2016-01-08 16:28 ` Nicolas Richard [this message]
2016-01-31 22:11 ` Nicolas Goaziou
2016-02-03 23:04 ` Thorsten Jolitz
2016-02-03 23:02 ` Thorsten Jolitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1tc3ujc.fsf@ulb.ac.be \
--to=nrichard@ulb.ac.be \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=tjolitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).