From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Richard <nrichard@ulb.ac.be>
Subject: Re: Use of deprecated org-log-note-marker variable in outshine
Date: Fri, 08 Jan 2016 17:28:23 +0100
Message-ID: <87d1tc3ujc.fsf@ulb.ac.be>
References: <CAFyQvY1gCBnv5axw-ZEcLE84eBzbJNYYVCm41OrKKmY9QEM_pw@mail.gmail.com>
	<87twmpny4m.fsf@gmail.com>
	<CAFyQvY0qeGocXXqwDjFqp5a7vXGtYhEmm7dLXK8G1ubpgRd12w@mail.gmail.com>
	<87vb74p5p6.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nrichard@ulb.ac.be>) id 1aHZtp-0002ox-H5
	for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 11:28:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nrichard@ulb.ac.be>) id 1aHZtl-0008QS-CL
	for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 11:28:25 -0500
Received: from mxin.ulb.ac.be ([164.15.128.112]:43357)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nrichard@ulb.ac.be>) id 1aHZtl-0008QM-6T
	for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 11:28:21 -0500
In-Reply-To: <87vb74p5p6.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Fri, 08 Jan 2016 14:21:41 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>, Thorsten Jolitz <tjolitz@gmail.com>

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Actually, it was a mistake to remove the variable in the first place. As
> a consequence, I re-introduced it in master.
>
> However, it doesn't store the same location as before, i.e., it merely
> points to the entry where the note is going to be added instead of the
> accurate location for the note.

Did you consider renaming it, in the case some code relies on it ?


>   (with-current-buffer (marker-buffer org-log-note-marker)
>     (goto-char (org-log-note-marker))
                 ^                   ^
                 I guess those parens are a typo.
>     (copy-marker (org-log-beginning)))

-- 
Nicolas