* Fixing mailto and irc links in ox-md.el
@ 2017-07-10 1:20 Jay Kamat
2017-07-10 8:26 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Jay Kamat @ 2017-07-10 1:20 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Hi!
I would like to submit a patch to org mode, which fixes the behavior
of mailto and irc links in markdown export.
Previously, these org mode snippets:
[[mailto:some.email@server.net][Jane Doe]]
[[irc:/irc.com/#emacs/bob][bob]]
would export to:
[Jane Doe](some.email@server.net)
[bob](/irc.com/#emacs/bob)
which causes broken links in browsers when they try to view exported markdown.
The new behavior exports them to:
[Jane Doe](mailto:some.email@server.net)
[bob](irc:/irc.com/#emacs/bob)
so that browsers can open the proper respective application when
opening said links.
The patch that I have made is very small (only one line), and is attached.
There is an external report of this bug here:
https://github.com/larstvei/ox-gfm/issues/17
This is my first time submitting a patch to anything big like org
mode, so please let me know if I've done anything wrong or if anything
seems amiss.
Thanks for looking at this, and thanks for making/developing on org
mode (it's changed my life completely)!
-Jay Kamat
[-- Attachment #2: 0001-ox-md.el-Fix-export-of-irc-and-mailto-links.patch --]
[-- Type: text/x-patch, Size: 971 bytes --]
From 0ef21fcd6394b3551a94a5878d414f2e7d17e372 Mon Sep 17 00:00:00 2001
From: Jay Kamat <jaygkamat@gmail.com>
Date: Sun, 9 Jul 2017 17:50:09 -0700
Subject: [PATCH] ox-md.el: Fix export of irc and mailto links
* lisp/ox-md.el (org-md-link): Add mailto and irc to links that pass
their types through to markdown export
See: https://github.com/larstvei/ox-gfm/issues/17 for an external
bug report
TINYCHANGE
---
lisp/ox-md.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox-md.el b/lisp/ox-md.el
index e2b3d29e1..08e385282 100644
--- a/lisp/ox-md.el
+++ b/lisp/ox-md.el
@@ -448,7 +448,7 @@ a communication channel."
(t (let* ((raw-path (org-element-property :path link))
(path
(cond
- ((member type '("http" "https" "ftp"))
+ ((member type '("http" "https" "ftp" "mailto" "irc"))
(concat type ":" raw-path))
((string= type "file")
(org-export-file-uri (funcall link-org-files-as-md raw-path)))
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Fixing mailto and irc links in ox-md.el
2017-07-10 1:20 Fixing mailto and irc links in ox-md.el Jay Kamat
@ 2017-07-10 8:26 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-07-10 8:26 UTC (permalink / raw)
To: Jay Kamat; +Cc: emacs-orgmode
Hello,
Jay Kamat <jaygkamat@gmail.com> writes:
> Subject: [PATCH] ox-md.el: Fix export of irc and mailto links
>
> * lisp/ox-md.el (org-md-link): Add mailto and irc to links that pass
> their types through to markdown export
>
> See: https://github.com/larstvei/ox-gfm/issues/17 for an external
> bug report
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-10 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 1:20 Fixing mailto and irc links in ox-md.el Jay Kamat
2017-07-10 8:26 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).