emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]
Date: Sat, 22 Jul 2023 13:48:07 +0000	[thread overview]
Message-ID: <87y1j8rrag.fsf@localhost> (raw)
In-Reply-To: <2fa5914d-2cbf-f41f-8be6-e79e77794140@vodafonemail.de>

Jens Schmidt <jschmidt4gnu@vodafonemail.de> writes:

> The most obvious symptom is this:
>
> - Create an nnselect group and open an article from that.  In the
>    article buffer, do M-x org-store-link RET, then paste the link with
>    C-c C-l in some Org mode buffer.  The resulting link looks like
>
>      gnus:#E18xcfu-0004HT-00@fencepost.gnu.org
>
>    That is, it lacks the group name before the hash sign.  Correct would
>    have been:
>
>      gnus:nnml+archive:test01#E18xcfu-0004HT-00@fencepost.gnu.org
>
>    Starting with Emacs 30, you even more obviously get an error:
>
>      Debugger entered--Lisp error: (wrong-type-argument 
> number-or-marker-p nil)

Thanks for reporting!
ol-gnus is not very actively maintained, so there be dragons.

> The root cause is that some of the Gnus functions used in
> `org-gnus-store-link' must be called only in summary buffers, and not in
> article buffers.  These are:
>
>    gnus-summary-article-number
>    nnselect-article-group
>
> Not sure about these, but it is probably also better to call these in
> summary buffers only:
>
>    nnvirtual-map-article
>    nnir-article-group
>
> The remedy for these issues is simple: When calling above functions just
> temporarily and unconditionally switch to the summary buffer with
>
>    (with-current-buffer gnus-summary-buffer ...)
>
> where buffer-local variable `gnus-summary-buffer' in an article buffer
> points to the summary buffer where the articles comes from.  (And for
> a summary buffer the variable points to the summary buffer itself.)

I am not familiar with Gnus, but looking at the code, may it be that a
Gnus article is open when Gnus summary buffer is not?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-07-22 13:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22  9:06 [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] Jens Schmidt
2023-07-22 13:48 ` Ihor Radchenko [this message]
2023-07-22 15:37   ` Jens Schmidt
2023-07-22 21:09     ` Eric Abrahamsen
2023-07-23  6:45       ` Ihor Radchenko
2023-07-24  1:55         ` Eric Abrahamsen
2023-07-24  7:17           ` Ihor Radchenko
2023-07-24 20:23     ` Jens Schmidt
2023-07-25  7:16       ` Ihor Radchenko
2023-07-27 16:10       ` Eric Abrahamsen
2023-07-23 10:26 ` Max Nikulin
2023-07-23 14:13   ` Jens Schmidt
2023-07-24 14:54     ` Max Nikulin
2023-07-26 16:04 ` Ihor Radchenko
2023-07-26 19:36   ` Jens Schmidt
2023-07-27  7:56     ` Ihor Radchenko
2023-07-28 11:27       ` Bastien Guerry
2023-07-29  7:04         ` Ihor Radchenko
2023-07-30 15:57           ` Jens Schmidt
2023-07-30 16:35             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1j8rrag.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=jschmidt4gnu@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).