From: Ihor Radchenko <yantar92@posteo.net>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-orgmode@gnu.org
Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]
Date: Tue, 25 Jul 2023 07:16:28 +0000 [thread overview]
Message-ID: <87a5vk796b.fsf@localhost> (raw)
In-Reply-To: <6aa47402-1546-272b-2859-4cfed1ea9ceb@vodafonemail.de>
Jens Schmidt <jschmidt4gnu@vodafonemail.de> writes:
> > Ideally, it would be nice to have tests, though I have no clue how to
> > approach writing them.
>
> I have created a somewhat minimal Gnus setup to develop and test this
> patch on my development laptop, where I normally do not use Gnus. It
> consists of a bunch of files and directories and a bit of configuration.
> I can follow up on this if you like, but preferably in a separate
> thread.
That would be welcome. Thanks in advance!
> >> Probably it would be enough to wrap the whole containing `let*' in a
> >> (with-current-buffer gnus-summary-buffer ...). If we're already in the
> >> summary buffer, no harm done.
> >
> > I am not sure if it is safe.
> > There is
> > (save-window-excursion (gnus-summary-select-article))
> > which calls (set-buffer gnus-summary-buffer)
>
> I agree with Ihor here and would rather go for individual wraps into
> `with-current-buffer'. As I have done in my patch already,
> incidentially.
Ok. Then, if no further objections, I will apply the patch tomorrow.
> > ol-gnus should store link for thing at point in current buffer. Ideally,
> > without side effects. Everything else should be implementation detail.
>
> Could we agree on: ol-gnus should store Gnus links with as little effort
> and side-effect as possible while providing reasonable functionality for
> the common use cases. I think, again incidentially, that my patch
> matches this criterion.
>
> What optionally could be improved, though, is error handling in these
> pathological cases. But that would probably require some macro
>
> (ol-gnus-with-current-summary-buffer BODY)
>
> to have the error handling available in the separate places. Not sure
> whether this is worth the effort.
We haven't had many bug reports about ol-gnus in the past, so I do not
have much statistics on whether getting such errors is common.
I do not think that implementing error handling is worth an effort here.
If killing summary buffer is already calling for trouble when using
Gnus itself, Org mode handling the error will not make things much
better.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-25 7:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 9:06 [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] Jens Schmidt
2023-07-22 13:48 ` Ihor Radchenko
2023-07-22 15:37 ` Jens Schmidt
2023-07-22 21:09 ` Eric Abrahamsen
2023-07-23 6:45 ` Ihor Radchenko
2023-07-24 1:55 ` Eric Abrahamsen
2023-07-24 7:17 ` Ihor Radchenko
2023-07-24 20:23 ` Jens Schmidt
2023-07-25 7:16 ` Ihor Radchenko [this message]
2023-07-27 16:10 ` Eric Abrahamsen
2023-07-23 10:26 ` Max Nikulin
2023-07-23 14:13 ` Jens Schmidt
2023-07-24 14:54 ` Max Nikulin
2023-07-26 16:04 ` Ihor Radchenko
2023-07-26 19:36 ` Jens Schmidt
2023-07-27 7:56 ` Ihor Radchenko
2023-07-28 11:27 ` Bastien Guerry
2023-07-29 7:04 ` Ihor Radchenko
2023-07-30 15:57 ` Jens Schmidt
2023-07-30 16:35 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5vk796b.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).