emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fix iswitchb completion when virtual buffers are enabled
@ 2009-09-16 19:04 Tassilo Horn
  2009-09-16 20:36 ` Carsten Dominik
  0 siblings, 1 reply; 3+ messages in thread
From: Tassilo Horn @ 2009-09-16 19:04 UTC (permalink / raw)
  To: emacs-orgmode

Hi Carsten,

there's a typo in org.el which prevents deactivation of virtual buffers
when the iswitchb completion is used in org.  Here's a patch.

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org.el b/lisp/org.el
index 4ef4a09..c364f1d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -7724,7 +7724,7 @@ Use TAB to complete link prefixes, then RET for type-specific completion support
   "Use iswitch as a completing-read replacement to choose from choices.
 PROMPT is a string to prompt with.  CHOICES is a list of strings to choose
 from."
-  (let* ((switchb-use-virtual-buffers nil)
+  (let* ((iswitchb-use-virtual-buffers nil)
 	 (iswitchb-make-buflist-hook
 	  (lambda ()
 	    (setq iswitchb-temp-buflist choices))))
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix iswitchb completion when virtual buffers are enabled
  2009-09-16 19:04 [PATCH] Fix iswitchb completion when virtual buffers are enabled Tassilo Horn
@ 2009-09-16 20:36 ` Carsten Dominik
  2009-09-17  6:25   ` Tassilo Horn
  0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2009-09-16 20:36 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: emacs-orgmode

Applied, thanks.

- Carsten

On Sep 16, 2009, at 8:04 PM, Tassilo Horn wrote:

> Hi Carsten,
>
> there's a typo in org.el which prevents deactivation of virtual  
> buffers
> when the iswitchb completion is used in org.  Here's a patch.
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/org.el b/lisp/org.el
> index 4ef4a09..c364f1d 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -7724,7 +7724,7 @@ Use TAB to complete link prefixes, then RET  
> for type-specific completion support
>   "Use iswitch as a completing-read replacement to choose from  
> choices.
> PROMPT is a string to prompt with.  CHOICES is a list of strings to  
> choose
> from."
> -  (let* ((switchb-use-virtual-buffers nil)
> +  (let* ((iswitchb-use-virtual-buffers nil)
> 	 (iswitchb-make-buflist-hook
> 	  (lambda ()
> 	    (setq iswitchb-temp-buflist choices))))
> --8<---------------cut here---------------end--------------->8---
>
> Bye,
> Tassilo
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix iswitchb completion when virtual buffers are enabled
  2009-09-16 20:36 ` Carsten Dominik
@ 2009-09-17  6:25   ` Tassilo Horn
  0 siblings, 0 replies; 3+ messages in thread
From: Tassilo Horn @ 2009-09-17  6:25 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Applied, thanks.

But at least not committed or pushed.

> On Sep 16, 2009, at 8:04 PM, Tassilo Horn wrote:
>
>> Hi Carsten,
>>
>> there's a typo in org.el which prevents deactivation of virtual buffers
>> when the iswitchb completion is used in org.  Here's a patch.
>>
>> --8<---------------cut here---------------start------------->8---
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 4ef4a09..c364f1d 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -7724,7 +7724,7 @@ Use TAB to complete link prefixes, then RET for
>> type-specific completion support
>>   "Use iswitch as a completing-read replacement to choose from choices.
>> PROMPT is a string to prompt with.  CHOICES is a list of strings to choose
>> from."
>> -  (let* ((switchb-use-virtual-buffers nil)
>> +  (let* ((iswitchb-use-virtual-buffers nil)
>> 	 (iswitchb-make-buflist-hook
>> 	  (lambda ()
>> 	    (setq iswitchb-temp-buflist choices))))
>> --8<---------------cut here---------------end--------------->8---
>>
>> Bye,
>> Tassilo
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-17  6:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16 19:04 [PATCH] Fix iswitchb completion when virtual buffers are enabled Tassilo Horn
2009-09-16 20:36 ` Carsten Dominik
2009-09-17  6:25   ` Tassilo Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).